From owner-freebsd-hackers@FreeBSD.ORG Tue Mar 5 14:57:35 2013 Return-Path: Delivered-To: freebsd-hackers@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by hub.freebsd.org (Postfix) with ESMTP id 2C80371C; Tue, 5 Mar 2013 14:57:35 +0000 (UTC) (envelope-from dim@FreeBSD.org) Received: from tensor.andric.com (tensor.andric.com [IPv6:2001:7b8:3a7:1:2d0:b7ff:fea0:8c26]) by mx1.freebsd.org (Postfix) with ESMTP id DADE0681; Tue, 5 Mar 2013 14:57:34 +0000 (UTC) Received: from [IPv6:2001:7b8:3a7:0:204:4bff:fe01:de8a] (spaceball.andric.com [IPv6:2001:7b8:3a7:0:204:4bff:fe01:de8a]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by tensor.andric.com (Postfix) with ESMTPSA id 159AE5C43; Tue, 5 Mar 2013 15:57:32 +0100 (CET) Message-ID: <513607DA.60901@FreeBSD.org> Date: Tue, 05 Mar 2013 15:57:30 +0100 From: Dimitry Andric Organization: The FreeBSD Project User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:19.0) Gecko/20130117 Thunderbird/19.0 MIME-Version: 1.0 To: Andriy Gapon Subject: Re: clang generated code sometimes confuses fbt References: <5132387E.8010808@FreeBSD.org> <51323C62.4040506@FreeBSD.org> <51325FB3.7080300@FreeBSD.org> <51337018.30000@FreeBSD.org> <51337C27.7000105@FreeBSD.org> <5133AC3B.5040504@FreeBSD.org> <51348A6A.3070606@FreeBSD.org> <5135DEF0.2060802@FreeBSD.org> In-Reply-To: <5135DEF0.2060802@FreeBSD.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: freebsd-hackers@FreeBSD.org X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 05 Mar 2013 14:57:35 -0000 On 2013-03-05 13:02, Andriy Gapon wrote: > on 04/03/2013 13:50 Dimitry Andric said the following: >> Actually, that way of fixing breaks it for gcc, so it should really be >> fixed in sort_iidescs() instead. See attached diff; I verified it works >> for both gcc-compiled and clang-compiled objects. > > Impossible! It looks like the attached diff was a nop change :-) > > BTW, so changing clang to match gcc is not an option? > I do not insist, just curious. I could not find a good argument to present to upstream to change this behaviour, except "gcc has been doing it for x years, without a good reason". :-) And I did not want to make yet another FreeBSD specific change. In my opinion, gcc is losing information here, e.g. the original pathname to the source file. There is no reason debugging tools cannot be fixed to be able to cope with this.