From owner-svn-ports-all@FreeBSD.ORG Wed Nov 28 22:38:15 2012 Return-Path: Delivered-To: svn-ports-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id BF402150 for ; Wed, 28 Nov 2012 22:38:15 +0000 (UTC) (envelope-from lists@eitanadler.com) Received: from mail-lb0-f182.google.com (mail-lb0-f182.google.com [209.85.217.182]) by mx1.freebsd.org (Postfix) with ESMTP id 2D26E8FC16 for ; Wed, 28 Nov 2012 22:38:14 +0000 (UTC) Received: by mail-lb0-f182.google.com with SMTP id go10so11021296lbb.13 for ; Wed, 28 Nov 2012 14:38:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=eitanadler.com; s=0xdeadbeef; h=mime-version:sender:in-reply-to:references:from:date :x-google-sender-auth:message-id:subject:to:cc:content-type; bh=GMAD20DiRfr98qnL+Hz2uol08L1xAHJ3qlDFMe4M2fg=; b=XetPPSAZFFMaxAJoV36mv0Nn8SjaufWyhmI3yc4WjQNjhC11PEDa4LvOGmRkON8H01 caiSMVxSbNCYUOin34qjjHXtyWzYUJ80lBgaqoxTxG3Lvmw4D3Db0hbbK8TrfclA7wyD c8de8JyRhp8bxZNI+fY+vdiKBXrrQP+vWKLCU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:sender:in-reply-to:references:from:date :x-google-sender-auth:message-id:subject:to:cc:content-type :x-gm-message-state; bh=GMAD20DiRfr98qnL+Hz2uol08L1xAHJ3qlDFMe4M2fg=; b=TV1Q757vZT5nu/bSPkWBVDa/PeWXYzmFljBheG33js5hodheY2cgGsX95wxUxBzJwm WBPW3E9UPZmlK6+RvaITSVMGJevLOdyE5ZVyPIxhk6fOnuvVeE1oEspaWXIQNyvtHWC7 9soL5r1VY1AU1An16dXeE/NSbFeG9iXELurr4lsjBEpGbi4d3Gx5vvG62/8KEZGy6sF6 XoZMji0afIJ+rnUYwGE8jrYSNWxUj95URvxseUY30vAZ/8gxA848y6O0rvc8gQxGnNVL t/ueLsB6vGruFCYlmviTocypWQychgh5imS5nW+idFyMOLl4Dvwe6F5kJSG0yVzT3lcB 4utA== Received: by 10.112.103.135 with SMTP id fw7mr3978291lbb.17.1354142293943; Wed, 28 Nov 2012 14:38:13 -0800 (PST) MIME-Version: 1.0 Sender: lists@eitanadler.com Received: by 10.112.154.168 with HTTP; Wed, 28 Nov 2012 14:37:43 -0800 (PST) In-Reply-To: <20121128213502.b5cd8fab508df17bad16c635@FreeBSD.org> References: <201211281129.qASBT6Aw015051@svn.freebsd.org> <20121128213502.b5cd8fab508df17bad16c635@FreeBSD.org> From: Eitan Adler Date: Wed, 28 Nov 2012 17:37:43 -0500 X-Google-Sender-Auth: 24htgAm3vpqFSf8m75dRBZRnmYQ Message-ID: Subject: Re: svn commit: r307902 - head/graphics/grafx2/files To: Emanuel Haupt Content-Type: text/plain; charset=UTF-8 X-Gm-Message-State: ALoCoQmrGb+N6XmiH0bYLRolzk31sFNbFHyOGstTfuxH/Ozv1h18I0PFL0hnxGgqDnCSHQhbFgxJ Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 28 Nov 2012 22:38:15 -0000 On 28 November 2012 15:35, Emanuel Haupt wrote: > Eitan Adler wrote: >> On 28 November 2012 06:29, Emanuel Haupt wrote: >> > Author: ehaupt >> > Date: Wed Nov 28 11:29:06 2012 >> > New Revision: 307902 >> > URL: http://svnweb.freebsd.org/changeset/ports/307902 >> > >> > Log: >> > Add patchfile. >> >> What does the patchfile do? Why is it needed? Was upstream contacted? >> >> - these should be documented in the log message. > > It is part of the update 2 minutes earlier. I thought this was obvious. Ah, I didn't see this. In any case it would help to document these things - especially the part about whether upstream ACKed/NACKed the patch. -- Eitan Adler Source, Ports, Doc committer Bugmeister, Ports Security teams