Date: Tue, 4 Dec 2012 20:45:43 -0500 From: Eitan Adler <eadler@freebsd.org> To: Alexey Dokuchaev <danfe@freebsd.org> Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, Chris Rees <utisoft@gmail.com>, ports-committers@freebsd.org Subject: Re: svn commit: r308260 - head/net-mgmt/p5-Net-IP Message-ID: <CAF6rxgkt=KU%2BoHg1eKZAS8GdwRNhCshZdEtzZ4vskDsqAxrxLA@mail.gmail.com> In-Reply-To: <20121205012842.GB45591@FreeBSD.org> References: <201212041815.qB4IFB55053423@svn.freebsd.org> <CADLo83-P5rrRr=9GEOMi7km=HiZzd5KLXJygOToMah54h5mdgg@mail.gmail.com> <20121205012842.GB45591@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 4 December 2012 20:28, Alexey Dokuchaev <danfe@freebsd.org> wrote:
> On Tue, Dec 04, 2012 at 06:54:18PM +0000, Chris Rees wrote:
>> On 4 Dec 2012 18:15, "Eitan Adler" <eadler@freebsd.org> wrote:
>> > post-patch:
>> > - @${CP} ${WRKSRC}/IP.pm ${WRKSRC}/IP.pm.presed
>> > - @${SED} -e "1853s#\\s+#\s*#g" ${WRKSRC}/IP.pm.presed > \
>> > - ${WRKSRC}/IP.pm
>> > - @${CP} ${WRKSRC}/ipcount ${WRKSRC}/ipcount.presed
>> > - @${SED} -e "76s#count#count = 0#" ${WRKSRC}/ipcount.presed > \
>> > - ${WRKSRC}/ipcount
>> > + ${REINPLACE_CMD} "1853s#\\s+#\s*#g" ${WRKSRC}/IP.pm
>> > + ${REINPLACE_CMD} "76s#count#count = 0#" ${WRKSRC}/ipcount
>>
>> These are horrible- why not patches?
>
> There *were* horrible; now they are pretty much clear and trivial. While it
> is largely the matter of taste, I also prefer to perform simple mechanical
> changes with sed(1) and use patches for some more complicated logic.
They remain horrible because they use sed to modify a specific line.
That said, I'll leave them for now and revisit when I update the port.
--
Eitan Adler
Source, Ports, Doc committer
Bugmeister, Ports Security teams
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAF6rxgkt=KU%2BoHg1eKZAS8GdwRNhCshZdEtzZ4vskDsqAxrxLA>