Date: Thu, 11 Sep 2008 01:46:04 GMT From: "Eric L. Chen" <d9364104@mail.nchu.edu.tw> To: freebsd-gnats-submit@FreeBSD.org Subject: ports/127285: Fix Banshee (NDesk.DBus component) crash in radio listening when pidgin-musictrack enabled. Message-ID: <200809110146.m8B1k4CB046950@www.freebsd.org> Resent-Message-ID: <200809110150.m8B1o0kw098297@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 127285
>Category: ports
>Synopsis: Fix Banshee (NDesk.DBus component) crash in radio listening when pidgin-musictrack enabled.
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-ports-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: sw-bug
>Submitter-Id: current-users
>Arrival-Date: Thu Sep 11 01:50:00 UTC 2008
>Closed-Date:
>Last-Modified:
>Originator: Eric L. Chen
>Release: 7-STABLE
>Organization:
National Chung Hsing University
>Environment:
FreeBSD lihong-nb.local 7.1-PRERELEASE FreeBSD 7.1-PRERELEASE #4: Fri Sep 5 09:03:19 CST 2008 root@lihong-nb.local:/usr/obj/usr/src/sys/lihong-nb i386
>Description:
If you enabled musictracker plugin in pidgin, and listen internet radio with banshee, banshee will crash.
>How-To-Repeat:
1. Start pidgin.
2. Enable plugin musictracker in pidgin.
3. Start banshee.
4. Use banshee to listen (streaming) radio.
5. Then banshee pop-up a windows, said NDesk.DBus sent null item.
>Fix:
Don't put any null item to NDesk.DBus.
Patch attached with submission follows:
# This is a shell archive. Save it in a file, remove anything before
# this line, and then unpack it by entering "sh file". Note, it may
# create directories; files and directories will be owned by you and
# have default permissions.
#
# This archive contains:
#
# multimedia/banshee/files/patch-src_Core_Banshee.Core_Banshee.Collection_TrackInfo.cs
#
echo x - multimedia/banshee/files/patch-src_Core_Banshee.Core_Banshee.Collection_TrackInfo.cs
sed 's/^X//' >multimedia/banshee/files/patch-src_Core_Banshee.Core_Banshee.Collection_TrackInfo.cs << '99a43e07186b11733162a4242fd36f82'
X--- src/Core/Banshee.Core/Banshee.Collection/TrackInfo.cs.orig 2008-09-11 09:01:14.000000000 +0800
X+++ src/Core/Banshee.Core/Banshee.Collection/TrackInfo.cs 2008-09-11 09:14:56.000000000 +0800
X@@ -356,17 +356,17 @@
X
X // Properties specified by the XMMS2 player spec
X dict.Add ("URI", Uri == null ? String.Empty : Uri.AbsoluteUri);
X- dict.Add ("length", Duration.TotalSeconds);
X- dict.Add ("name", TrackTitle);
X- dict.Add ("artist", ArtistName);
X- dict.Add ("album", AlbumTitle);
X+ dict.Add ("length", Duration == null ? 0 : Duration.TotalSeconds);
X+ dict.Add ("name", TrackTitle == null ? String.Empty : TrackTitle);
X+ dict.Add ("artist", ArtistName == null ? String.Empty : ArtistName);
X+ dict.Add ("album", AlbumTitle == null ? String.Empty : AlbumTitle);
X
X // Our own
X- dict.Add ("track-number", TrackNumber);
X- dict.Add ("track-count", TrackCount);
X- dict.Add ("disc", Disc);
X- dict.Add ("year", year);
X- dict.Add ("rating", rating);
X+ dict.Add ("track-number", TrackNumber == null ? 0 : TrackNumber);
X+ dict.Add ("track-count", TrackCount == null ? 0 : TrackCount);
X+ dict.Add ("disc", Disc == null ? 0 : Disc);
X+ dict.Add ("year", year == null ? 0 : year);
X+ dict.Add ("rating", rating == null ? 0 : rating);
X
X return dict;
X }
99a43e07186b11733162a4242fd36f82
exit
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200809110146.m8B1k4CB046950>