From owner-cvs-ports@FreeBSD.ORG  Sun Jan  4 20:21:35 2009
Return-Path: <owner-cvs-ports@FreeBSD.ORG>
Delivered-To: cvs-ports@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 8EC171065672
	for <cvs-ports@FreeBSD.org>; Sun,  4 Jan 2009 20:21:35 +0000 (UTC)
	(envelope-from dougb@FreeBSD.org)
Received: from mail2.fluidhosting.com (mx22.fluidhosting.com [204.14.89.5])
	by mx1.freebsd.org (Postfix) with ESMTP id 1C8C08FC17
	for <cvs-ports@FreeBSD.org>; Sun,  4 Jan 2009 20:21:35 +0000 (UTC)
	(envelope-from dougb@FreeBSD.org)
Received: (qmail 2244 invoked by uid 399); 4 Jan 2009 20:21:34 -0000
Received: from localhost (HELO lap.dougb.net) (dougb@dougbarton.us@127.0.0.1)
	by localhost with ESMTPAM; 4 Jan 2009 20:21:34 -0000
X-Originating-IP: 127.0.0.1
X-Sender: dougb@dougbarton.us
Message-ID: <49611A4C.9030804@FreeBSD.org>
Date: Sun, 04 Jan 2009 12:21:32 -0800
From: Doug Barton <dougb@FreeBSD.org>
Organization: http://www.FreeBSD.org/
User-Agent: Thunderbird 2.0.0.19 (X11/20090102)
MIME-Version: 1.0
To: Martin Wilke <miwi@FreeBSD.org>
References: <200812252024.mBPKOhS1087071@repoman.freebsd.org>
In-Reply-To: <200812252024.mBPKOhS1087071@repoman.freebsd.org>
X-Enigmail-Version: 0.95.7
OpenPGP: id=D5B2F0FB
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Cc: cvs-ports@FreeBSD.org, Eygene Ryabinkin <rea-fbsd@codelabs.ru>,
	cvs-all@FreeBSD.org, ports-committers@FreeBSD.org
Subject: Re: cvs commit: ports/net-mgmt/nrpe2 Makefile
 ports/net-mgmt/nrpe2/files nrpe2.in
X-BeenThere: cvs-ports@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the ports tree <cvs-ports.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-ports>,
	<mailto:cvs-ports-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-ports>
List-Post: <mailto:cvs-ports@freebsd.org>
List-Help: <mailto:cvs-ports-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-ports>,
	<mailto:cvs-ports-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 04 Jan 2009 20:21:36 -0000

Martin Wilke wrote:
> miwi        2008-12-25 20:24:43 UTC
> 
>   FreeBSD ports repository
> 
>   Modified files:
>     net-mgmt/nrpe2       Makefile 
>     net-mgmt/nrpe2/files nrpe2.in 
>   Log:
>   - Modify rc.d script to allow administrator to change PID file location
>     without editing rc.d script.  New knob nrpe2_pidfile is provided for
>     this and it defaults to the old value of the PID file.
>   - Bump PORTREVISION
>   
>   PR:             129386  http://www.FreeBSD.org/cgi/query-pr.cgi?pr=129386
>   Submitted by:   Eygene Ryabinkin <rea-fbsd@codelabs.ru>
>   Approved by:    maintainer
>   
>   Revision  Changes    Path
>   1.26      +1 -0      ports/net-mgmt/nrpe2/Makefile
>   1.3       +5 -2      ports/net-mgmt/nrpe2/files/nrpe2.in
> 
> http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/net-mgmt/nrpe2/Makefile.diff?&r1=1.25&r2=1.26&f=h
> http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/net-mgmt/nrpe2/files/nrpe2.in.diff?&r1=1.2&r2=1.3&f=h

Overall the rc.d file looks pretty good, just a couple notes. You need
to move the load_rc_config line above the default variable
assignments, otherwise it's not very effective. I'm also unclear as to
why you have two assignments for command_args. Finally you might want
to consult
http://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/rc-scripts.html

hth,

Doug

-- 

    This .signature sanitized for your protection