Date: Mon, 13 Apr 2020 17:34:45 +0200 From: Harry Schmalzbauer <freebsd@omnilan.de> To: freebsd-ports@freebsd.org Subject: Mk/bsd.port.mk PORTS_FEATURES logic fix? Message-ID: <3fd259eb-21ff-4ccc-5cac-59e37151c67d@omnilan.de>
next in thread | raw e-mail | index | archive | help
Hello, just from an isolated view, line 1047 (https://svnweb.freebsd.org/ports/head/Mk/bsd.port.mk?view=markup&pathrev=529956) reads: if !defined(PORTS_FEATURES) && empty(${PORTS_FEATURES:MFLAVORS}) I guess the negation was swapped, since ${PORTS_FEATURES:MFLAVORS} is always empty if ${PORTS_FEATURES} is undefined, is it? Never looked at PORTS_FEATURES, but what's the meaning if FLAVORS is added unconditionally – even if the tautological if statement was fixed, it's still unconditionally set… Thanks, -harry
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?3fd259eb-21ff-4ccc-5cac-59e37151c67d>