Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 04 Nov 2013 08:15:52 -0600
From:      Mark Felder <feld@FreeBSD.org>
To:        Eitan Adler <eadler@freebsd.org>, Tijl Coosemans <tijl@freebsd.org>
Cc:        svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org
Subject:   Re: svn commit: r332567 - head/graphics/apvlv
Message-ID:  <1383574552.17263.42707017.6BE762CA@webmail.messagingengine.com>
In-Reply-To: <CAF6rxgn4Bj9J%2Bre5V9yZNNZFTyX5o8EWDG7%2BN4WpJEGbK24Egg@mail.gmail.com>
References:  <201311030036.rA30aXLv016213@svn.freebsd.org> <20131103201410.2f95dc09@kalimero.tijl.coosemans.org> <CAF6rxgn4Bj9J%2Bre5V9yZNNZFTyX5o8EWDG7%2BN4WpJEGbK24Egg@mail.gmail.com>

next in thread | previous in thread | raw e-mail | index | archive | help


On Sun, Nov 3, 2013, at 13:38, Eitan Adler wrote:
> On Sun, Nov 3, 2013 at 2:14 PM, Tijl Coosemans <tijl@freebsd.org> wrote:
> 
> > but now PTHREAD_CFLAGS is always empty
> 
> Which is always a mistake.  PTHREAD_CFLAGS should be replaced with
> -pthread
> 
>  so you can remove that line and PTHREAD_LIBS is always
> > -pthread.
> 
> As should this.
> 

Thanks for the feedback guys. Perhaps we should put PTHREAD_CFLAGS and
PTHREAD_LIBS into portlint as well.

I'm not 100% sure I understand the changes you're proposing -- I'm
getting caught up on the wording. Is this diff what you're suggesting?

--- Makefile    (revision 332703)
+++ Makefile    (working copy)
@@ -22,8 +22,8 @@
                -DDOCDIR=${DOCSDIR} \
                -DAPVLV_WITH_UMD=OFF \
                -DAPVLV_WITH_TXT=ON
-CFLAGS+=       ${PTHREAD_CFLAGS}
-LDFLAGS+=      ${PTHREAD_LIBS}
+CFLAGS+=       -pthread
+LDFLAGS+=      -pthread
 
 OPTIONS_DEFINE=        DJVU WEBKIT



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1383574552.17263.42707017.6BE762CA>