Date: Mon, 11 Jul 2005 10:44:51 -0400 From: John Baldwin <jhb@FreeBSD.org> To: "Wilkinson, Alex" <alex.wilkinson@dsto.defence.gov.au> Cc: Poul-Henning Kamp <phk@haven.freebsd.dk>, freebsd-current@freebsd.org, current@freebsd.org Subject: Re: [TEST/REVIEW] boot0cfg/fdisk issue fix Message-ID: <200507111044.52693.jhb@FreeBSD.org> In-Reply-To: <20050710072752.GA39156@squash.dsto.defence.gov.au> References: <200507090932.12973.jhb@FreeBSD.org> <20514.1120916772@phk.freebsd.dk> <20050710072752.GA39156@squash.dsto.defence.gov.au>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sunday 10 July 2005 03:27 am, Wilkinson, Alex wrote: > 0n Sat, Jul 09, 2005 at 03:46:12PM +0200, Poul-Henning Kamp wrote: > >In message <200507090932.12973.jhb@FreeBSD.org>, John Baldwin writes: > >>On Tuesday 05 July 2005 04:44 pm, Poul-Henning Kamp wrote: > >>> This is an attempt to fix an boot0cfg/fdisk issue which I have > >>> overlooked. > >>> > >>> The patch adds a g_ctl method to geom_mbr and makes boot0cfg and > >>> fdisk use it to modify the MBR if possible. > >>> > >>> Please test and report ASAP in order to get this solution into > >>> RELENG_6 > >> > >>Only thing I noted is that it seems that you changed boot0 to always > >> only write 512 bytes which means it will break trying to use > >> boot0cfg to install boot0ext (which is 2 sectors). Perhaps you > >> should check the filesize of the boot you are writing and if it's > > >> 512, write the other data with a write(2) after the g_ctl()? > >> Perhaps I don't see quite understand what your g_ctl() is doing > >> though. > > > >Damn, didn't think of that... > > what is boot0ext ? It's a 2-sector variant of boot0 that includes extra logic to choose between CHS and LBA BIOS calls and a longer table of filesystem/OS names. -- John Baldwin <jhb@FreeBSD.org> <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve" = http://www.FreeBSD.org
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200507111044.52693.jhb>