From owner-freebsd-net@FreeBSD.ORG Wed Jul 15 07:59:25 2009 Return-Path: Delivered-To: net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 78D05106566B for ; Wed, 15 Jul 2009 07:59:25 +0000 (UTC) (envelope-from onemda@gmail.com) Received: from mail-fx0-f224.google.com (mail-fx0-f224.google.com [209.85.220.224]) by mx1.freebsd.org (Postfix) with ESMTP id 0334B8FC08 for ; Wed, 15 Jul 2009 07:59:24 +0000 (UTC) (envelope-from onemda@gmail.com) Received: by fxm24 with SMTP id 24so2922640fxm.43 for ; Wed, 15 Jul 2009 00:59:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :date:message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=JwA1B4c8wGVPETtux1NjFmquwJgPMumogcqECLUdk6Q=; b=ODJco3uTD6BGPcU00SKQeYMhmcQ9eReljz0Y5faIq/eS2kZX96gXR7AR7NXD9LOATQ F8ghrm5K93j7yXmEv+uSevj6+2eE+LHp8jV5QEk86RZnh5JGBBxbg8otNtltSsD4663M eBUFVIkTiGmy0Af+w9igxBMu3Qk+9RJ8XfcM0= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; b=Ff0Q+jhvPfwdKi+6wkgKWf5fn1HLAO8yCPbH3+rZx5N3o3v28Zfn2lBtfrTFgP4ggt C+wDey/DnR7/cBMTF38eSEfcy1hfSKXVAtSRgh2mBO/EeDxmn39veJtMvGOofApTv6Ye NJD6XnPf/4oMPvOjzedaF1QZLRtpP1mas3RxY= MIME-Version: 1.0 Received: by 10.204.78.131 with SMTP id l3mr7281238bkk.186.1247642845026; Wed, 15 Jul 2009 00:27:25 -0700 (PDT) In-Reply-To: <3a142e750907040333o3938c06y6369af6fa6976812@mail.gmail.com> References: <3a142e750906080809i381c4e6amd93da8a135ab9bd3@mail.gmail.com> <4A2D2EB1.3040702@errno.com> <1244477453.7794.2.camel@localhost> <3a142e750906081006v6369051dw75c5077e6032101f@mail.gmail.com> <1244656248.1701.53.camel@localhost> <3a142e750906101108v588e33dfsb0cb81f024c65cfb@mail.gmail.com> <1244658479.1701.56.camel@localhost> <3a142e750906101805re85136cif71eeeda2c641451@mail.gmail.com> <1245323702.1754.0.camel@localhost> <3a142e750907040333o3938c06y6369af6fa6976812@mail.gmail.com> Date: Wed, 15 Jul 2009 09:27:23 +0200 Message-ID: <3a142e750907150027t106edef5m767dd0319f83bd63@mail.gmail.com> From: "Paul B. Mahol" To: current@freebsd.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: net@freebsd.org Subject: Re: ndis lor: hal preemption lock X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 15 Jul 2009 07:59:25 -0000 On 7/4/09, Paul B. Mahol wrote: > On 6/18/09, Coleman Kane wrote: >> I've committed this one as r194432. > > Ah, that one introduced regression. > Switching ndisX up before creating vap will cause panic. > Here is fix: > > --- /sys/dev/if_ndis/if_ndis.c 2009-06-28 09:15:54.000000000 +0000 > +++ if_ndis.c 2009-07-04 10:23:41.000000000 +0000 > @@ -2292,6 +2292,8 @@ > ifp = sc->ifp; > ic = ifp->if_l2com; > vap = TAILQ_FIRST(&ic->ic_vaps); > + if (vap == NULL) > + return; > > if (!NDIS_INITIALIZED(sc)) { > DPRINTF(("%s: NDIS not initialized\n", __func__)); Bump! Please commit. -- Paul