From owner-cvs-src@FreeBSD.ORG Mon Sep 18 15:35:27 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 53C1C16A47E; Mon, 18 Sep 2006 15:35:27 +0000 (UTC) (envelope-from kib@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 2A70B43D6E; Mon, 18 Sep 2006 15:35:22 +0000 (GMT) (envelope-from kib@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k8IFZMhC010515; Mon, 18 Sep 2006 15:35:22 GMT (envelope-from kib@repoman.freebsd.org) Received: (from kib@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k8IFZMUO010514; Mon, 18 Sep 2006 15:35:22 GMT (envelope-from kib) Message-Id: <200609181535.k8IFZMUO010514@repoman.freebsd.org> From: Konstantin Belousov Date: Mon, 18 Sep 2006 15:35:22 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/kern vfs_mount.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Sep 2006 15:35:27 -0000 kib 2006-09-18 15:35:22 UTC FreeBSD src repository Modified files: sys/kern vfs_mount.c Log: Fix the race while waiting for coveredvp lock during unmount. The vnode may be recycled during the sleep, wrap the vn_lock with vhold/vdrop. Check that coveredvp still points to the same mp after sleep (needed because sleep dropped Giant). Move check for user rights for unmount after coveredvp lock is obtained. Tested by: Peter Holm Reviewed by: tegge Approved by: kan (mentor) MFC after: 2 weeks Revision Changes Path 1.232 +26 -12 src/sys/kern/vfs_mount.c