From owner-svn-src-head@FreeBSD.ORG  Fri Oct 19 10:08:48 2012
Return-Path: <owner-svn-src-head@FreeBSD.ORG>
Delivered-To: svn-src-head@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
 by hub.freebsd.org (Postfix) with ESMTP id 60B45718
 for <svn-src-head@FreeBSD.org>; Fri, 19 Oct 2012 10:08:48 +0000 (UTC)
 (envelope-from andre@freebsd.org)
Received: from c00l3r.networx.ch (c00l3r.networx.ch [62.48.2.2])
 by mx1.freebsd.org (Postfix) with ESMTP id BE4748FC1A
 for <svn-src-head@FreeBSD.org>; Fri, 19 Oct 2012 10:08:47 +0000 (UTC)
Received: (qmail 33722 invoked from network); 19 Oct 2012 11:47:32 -0000
Received: from c00l3r.networx.ch (HELO [127.0.0.1]) ([62.48.2.2])
 (envelope-sender <andre@freebsd.org>)
 by c00l3r.networx.ch (qmail-ldap-1.03) with SMTP
 for <glebius@FreeBSD.org>; 19 Oct 2012 11:47:32 -0000
Message-ID: <508126A9.9090500@freebsd.org>
Date: Fri, 19 Oct 2012 12:08:41 +0200
From: Andre Oppermann <andre@freebsd.org>
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64;
 rv:16.0) Gecko/20121010 Thunderbird/16.0.1
MIME-Version: 1.0
To: Gleb Smirnoff <glebius@FreeBSD.org>
Subject: Re: svn commit: r241688 - head/sys/net
References: <201210181408.q9IE8QwE053495@svn.freebsd.org>
 <20121018141120.GJ89655@FreeBSD.org>
In-Reply-To: <20121018141120.GJ89655@FreeBSD.org>
Content-Type: text/plain; charset=KOI8-R; format=flowed
Content-Transfer-Encoding: 7bit
Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org,
 src-committers@FreeBSD.org
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 19 Oct 2012 10:08:48 -0000

On 18.10.2012 16:11, Gleb Smirnoff wrote:
> On Thu, Oct 18, 2012 at 02:08:26PM +0000, Andre Oppermann wrote:
> A> Author: andre
> A> Date: Thu Oct 18 14:08:26 2012
> A> New Revision: 241688
> A> URL: http://svn.freebsd.org/changeset/base/241688
> A>
> A> Log:
> A>   Use LOG_WARNING level in in_attachdomain1() instead of printf().
> A>
> A>   Submitted by:	vijju.singh-at-gmail.com
> A>
> A> Modified:
> A>   head/sys/net/if.c
> A>
> A> Modified: head/sys/net/if.c
> A> ==============================================================================
> A> --- head/sys/net/if.c	Thu Oct 18 13:57:28 2012	(r241687)
> A> +++ head/sys/net/if.c	Thu Oct 18 14:08:26 2012	(r241688)
> A> @@ -711,8 +711,8 @@ if_attachdomain1(struct ifnet *ifp)
> A>  		return;
> A>  	if (ifp->if_afdata_initialized >= domain_init_status) {
> A>  		IF_AFDATA_UNLOCK(ifp);
> A> -		printf("if_attachdomain called more than once on %s\n",
> A> -		    ifp->if_xname);
> A> +		log(LOG_WARNING, "if_attachdomain called more than once "
> A> +		    "on %s\n", ifp->if_xname);
> A>  		return;
> A>  	}
> A>  	ifp->if_afdata_initialized = domain_init_status;
>
> It'll be even more perfect if done as
>
> "%s called more than once on %s\n", __func__, ifp->if_xname

Thanks, done in r241725.

> And do we need "\n" for log(9)?

Yes.

-- 
Andre