From owner-cvs-all Wed Aug 1 13:33:28 2001 Delivered-To: cvs-all@freebsd.org Received: from beppo.feral.com (beppo.feral.com [192.67.166.79]) by hub.freebsd.org (Postfix) with ESMTP id 8065637B401; Wed, 1 Aug 2001 13:33:20 -0700 (PDT) (envelope-from mjacob@feral.com) Received: from beppo (mjacob@beppo [192.67.166.79]) by beppo.feral.com (8.11.3/8.11.3) with ESMTP id f71KXJI20965; Wed, 1 Aug 2001 13:33:19 -0700 (PDT) (envelope-from mjacob@feral.com) Date: Wed, 1 Aug 2001 13:33:19 -0700 (PDT) From: Matthew Jacob X-Sender: mjacob@beppo Reply-To: mjacob@feral.com To: John Baldwin Cc: Matt Jacob , cvs-all@FreeBSD.org, cvs-committers@FreeBSD.org Subject: RE: cvs commit: src/sys/alpha/alpha clock.c In-Reply-To: Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG Oh- okay. I misunderstood. Will do. On Wed, 1 Aug 2001, John Baldwin wrote: > > On 01-Aug-01 Matt Jacob wrote: > > mjacob 2001/08/01 12:40:11 PDT > > > > Modified files: > > sys/alpha/alpha clock.c > > Log: > > Don't initialize a clock twice (it's not a function of number of > > cpus). > > Erm, that's not what that is there for. It is there because the clock is not > safe for SMP use. I.e., we only use that timecounter in a UP machine. We > don't call cpu_initclocks() multiple times. However, on the alpha we always > call hardclock() (and thus tc_windup()) on the boot CPU, thus it _might_ be > safe for us to use this timecounter on SMP systems. In any case, > cpu_initclocks() is only called once, so the 'once' variable is bogus. Please > revert that part for now. > > -- > > John Baldwin -- http://www.FreeBSD.org/~jhb/ > PGP Key: http://www.baldwin.cx/~john/pgpkey.asc > "Power Users Use the Power to Serve!" - http://www.FreeBSD.org/ > To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message