Date: Wed, 31 Oct 2012 16:25:54 -0700 From: Jim Harris <jim.harris@gmail.com> To: attilio@freebsd.org Cc: Ian Lepore <freebsd@damnhippie.dyndns.org>, Adrian Chadd <adrian@freebsd.org>, src-committers@freebsd.org, Andre Oppermann <andre@freebsd.org>, svn-src-all@freebsd.org, svn-src-head@freebsd.org, Peter Jeremy <peter@rulingia.com> Subject: Re: svn commit: r242402 - in head/sys: kern vm Message-ID: <CAJP=Hc_uSMPmgU9H6BxifJ-bvP05Gi%2BX6PrycG%2B-3xoHLaZKhg@mail.gmail.com> In-Reply-To: <CAJ-FndADYhn6yOEmR91-h0kUVxPZoOm34NwKUGrtYwvaWCXrFQ@mail.gmail.com> References: <201210311807.q9VI7IcX000993@svn.freebsd.org> <CAJ-FndDRkBS57e9mzZoJWX5ugJ0KBGxhMSO50KB8Wm8MFudjCA@mail.gmail.com> <1351707964.1120.97.camel@revolution.hippie.lan> <CAJ-FndC7QwpNAjzQTumqTY6Sj_RszXPwc0pbHv2-pRGMqbw0ww@mail.gmail.com> <CAJ-VmokqEFX4wQYh-ojo3kcWUPj5L-V_k0Nj-u3sQByVypkDFw@mail.gmail.com> <CAJ-FndCL7bpkbfaaR%2BaYQAxEBDmgip0QbrE5JhwnbTicSraz9g@mail.gmail.com> <20121031193020.GJ3309@server.rulingia.com> <1351712425.1120.109.camel@revolution.hippie.lan> <50918AAD.2090906@freebsd.org> <CAJ-FndADYhn6yOEmR91-h0kUVxPZoOm34NwKUGrtYwvaWCXrFQ@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Oct 31, 2012 at 3:55 PM, Attilio Rao <attilio@freebsd.org> wrote: > On Wed, Oct 31, 2012 at 8:31 PM, Andre Oppermann <andre@freebsd.org> > wrote: > > You can define CACHE_LINE_SIZE to 0 on those platforms. > > Or to make it even more granular there could be a CACHE_LINE_SIZE_LOCKS > > that is used for lock padding. > > I think that this is a bright idea, albeit under the condition that > just like CACHE_LINE_SIZE it won't change during STABLE branches > timeframe and that it must not be dependent by SMP option. > > What do you think about this patch?: > http://www.freebsd.org/~attilio/cache_line_size_locks.patch > Should CACHE_LINE_SIZE_LOCKS still be defined as CACHE_LINE_SIZE on arm, mips, etc. if SMP is enabled? This would ensure the padding that used to be there in vpglock doesn't go away. I'm also wondering if this should be named something different, perhaps LOCK_ALIGNMENT. -Jim
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAJP=Hc_uSMPmgU9H6BxifJ-bvP05Gi%2BX6PrycG%2B-3xoHLaZKhg>