From owner-svn-src-all@FreeBSD.ORG Thu Aug 14 15:46:09 2014 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 48DB35DB for ; Thu, 14 Aug 2014 15:46:09 +0000 (UTC) Received: from mail.egr.msu.edu (gribble.egr.msu.edu [35.9.37.169]) by mx1.freebsd.org (Postfix) with ESMTP id 222E92742 for ; Thu, 14 Aug 2014 15:46:08 +0000 (UTC) Received: from gribble (localhost [127.0.0.1]) by mail.egr.msu.edu (Postfix) with ESMTP id EC4562BB7D for ; Thu, 14 Aug 2014 11:46:00 -0400 (EDT) X-Virus-Scanned: amavisd-new at egr.msu.edu Received: from mail.egr.msu.edu ([127.0.0.1]) by gribble (gribble.egr.msu.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id XrMymJ1BYslU for ; Thu, 14 Aug 2014 11:46:00 -0400 (EDT) Received: from EGR authenticated sender Message-ID: <53ECD9B8.7000502@egr.msu.edu> Date: Thu, 14 Aug 2014 11:46:00 -0400 From: Adam McDougall User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:31.0) Gecko/20100101 Thunderbird/31.0 MIME-Version: 1.0 To: svn-src-all@freebsd.org Subject: Re: svn commit: r269975 - in stable/10: . sys/dev/ixgbe References: <201408141407.s7EE75lC013864@svn.freebsd.org> In-Reply-To: <201408141407.s7EE75lC013864@svn.freebsd.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 14 Aug 2014 15:46:09 -0000 On 08/14/2014 10:07, Steven Hartland wrote: > Author: smh > Date: Thu Aug 14 14:07:05 2014 > New Revision: 269975 > URL: http://svnweb.freebsd.org/changeset/base/269975 > > Log: > Make the ixgbe tunables now match their sysctl counterparts. > > Previously the tunables and sysctls had different names for example: > hw.ixgbe.enable_aim => hw.ix.enable_aim > > Anyone using ixgbe tunables should ensure they update /boot/loader.conf. > > This is a direct commit to stable as the changes to sysctls in head > already fix this issue in a different way. > > Sponsored by: Multiplay > Modified: stable/10/sys/dev/ixgbe/ixgbe.c > ============================================================================== > --- stable/10/sys/dev/ixgbe/ixgbe.c Thu Aug 14 13:57:17 2014 (r269974) > +++ stable/10/sys/dev/ixgbe/ixgbe.c Thu Aug 14 14:07:05 2014 (r269975) > @@ -244,18 +244,18 @@ static SYSCTL_NODE(_hw, OID_AUTO, ix, CT > ** traffic for that interrupt vector > */ > static int ixgbe_enable_aim = TRUE; > -TUNABLE_INT("hw.ixgbe.enable_aim", &ixgbe_enable_aim); > +TUNABLE_INT("hw.ix.enable_aim", &ixgbe_enable_aim); > SYSCTL_INT(_hw_ix, OID_AUTO, enable_aim, CTLFLAG_RW, &ixgbe_enable_aim, 0, > "Enable adaptive interrupt moderation"); I'm not using ix yet, but could you retain the old tunables in 10 as hidden ones so configurations do not break?