From owner-svn-src-all@FreeBSD.ORG Tue Nov 4 09:58:04 2014 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 5F05D593; Tue, 4 Nov 2014 09:58:04 +0000 (UTC) Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id C44CC2CC; Tue, 4 Nov 2014 09:58:03 +0000 (UTC) Received: from tom.home (kostik@localhost [127.0.0.1]) by kib.kiev.ua (8.14.9/8.14.9) with ESMTP id sA49vvP3073277 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Tue, 4 Nov 2014 11:57:57 +0200 (EET) (envelope-from kostikbel@gmail.com) DKIM-Filter: OpenDKIM Filter v2.9.2 kib.kiev.ua sA49vvP3073277 Received: (from kostik@localhost) by tom.home (8.14.9/8.14.9/Submit) id sA49vvVH073276; Tue, 4 Nov 2014 11:57:57 +0200 (EET) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: tom.home: kostik set sender to kostikbel@gmail.com using -f Date: Tue, 4 Nov 2014 11:57:57 +0200 From: Konstantin Belousov To: Tijl Coosemans Subject: Re: svn commit: r274040 - in head/sys: conf dev/agp Message-ID: <20141104095757.GQ53947@kib.kiev.ua> References: <201411031149.sA3BnaNe053503@svn.freebsd.org> <20141103195015.7d78af57@kalimero.tijl.coosemans.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20141103195015.7d78af57@kalimero.tijl.coosemans.org> User-Agent: Mutt/1.5.23 (2014-03-12) X-Spam-Status: No, score=-2.0 required=5.0 tests=ALL_TRUSTED,BAYES_00, DKIM_ADSP_CUSTOM_MED,FREEMAIL_FROM,NML_ADSP_CUSTOM_MED autolearn=no autolearn_force=no version=3.4.0 X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on tom.home Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 04 Nov 2014 09:58:04 -0000 On Mon, Nov 03, 2014 at 07:50:15PM +0100, Tijl Coosemans wrote: > On Mon, 3 Nov 2014 11:49:36 +0000 (UTC) Konstantin Belousov wrote: > > Author: kib > > Date: Mon Nov 3 11:49:35 2014 > > New Revision: 274040 > > URL: https://svnweb.freebsd.org/changeset/base/274040 > > > > Log: > > agp_intel.c provides support for AGP on Intel chipsets from 440/BX to > > 875. This intersects with the agp_i810.c, which supports all Intels > > from i810 to Core i5/7. Both agp_intel.c and agp_i810.c are compiled > > into kernel when device agp is specified in config, and agp_i810 > > attach seems to be selected by chance due to linking order. > > I think agp_intel are the plain AGP chipsets while agp_i810 are the > integrated graphics. None of the device IDs you deleted from agp_intel > appear in agp_i810. Hm, I am not aware of any i810 variants without IGP. The commit above sit in my local drm branch for long time, and was based on actual report by user who did experienced problems due to the agp_intel taking over aperture, instead of agp_i810. I see your point, and for now I reverted the pciid part of the change, 274084. I still think that removing agp_intel.c from amd64 static agp compilation is right thing to do. AFAIR EMT64-capable Pentium 4 (Prescotts ? I do not remember anymore) were compatible with 865/875 series, but it hardly matters.