From nobody Wed Aug 23 00:26:52 2023 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4RVn8p5Sw8z4qgxw for ; Wed, 23 Aug 2023 00:27:06 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-ej1-x629.google.com (mail-ej1-x629.google.com [IPv6:2a00:1450:4864:20::629]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4RVn8p1jySz4fDm for ; Wed, 23 Aug 2023 00:27:06 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-ej1-x629.google.com with SMTP id a640c23a62f3a-99c0290f0a8so640281466b.1 for ; Tue, 22 Aug 2023 17:27:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20221208.gappssmtp.com; s=20221208; t=1692750424; x=1693355224; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=CTYViZgAAcQhFBg8riPyx/UjVWzp+kRb4o5TeXlQsLA=; b=m7z5Hlu0LC9MTP1gdJcz7h46Nl9fpYqlfS7E+N4I5lxrGs3/ECWhToJ0Ia9/VU/iW5 9rVKIqrORYMsRvSy8IByj5vcSeIOnUFm0jq5qMfZXWBxqoQ4SAcXV87Gc5WFMC3QKkPF uM6yus6/nUtiTxiO5fEZMb3nPycbVjVAd9pabX5qvJ+GNyvjDLlR4xunqMXYNnKndXor 8igaES8dHdvYVdA/FFXY+8IdQSCu0iI4cV1wXmbl5vgkK4GMX7Vc6XYaRwXmJYUJuyOo 5MK3rupM5gn64YWN4CCR8m0femdk1b6zIOfJG4IDN3GIc/R5Rb+0r2VZ8vMOmUUbFMX8 v7XQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692750424; x=1693355224; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=CTYViZgAAcQhFBg8riPyx/UjVWzp+kRb4o5TeXlQsLA=; b=H54O8nvIhvNXjJQcRAhgGXrkmDkJOvk/YCnrJEya6la/24D2J426BiHlSKZe2URKiy uhTPZllN/GDwDPqwJdbbNePWrR/A46V/60uQ7VjeznVieaOqZNg+vl4y/s/AEIShXYP1 4ex2WsFJ+9N27wD87zejys8K/wDU2ePlSE/5/uwKf+tmFonxlE+ScH9sBK9hl5SVLuk+ x0cgvS2c+odaHVsxk3rZA6Yjsv0W7kkeI6rdYsPbaEF8qBMs4fy1No1ZtFMOVnKIQbEA m15cVbza0NciNCYkPJmQC2YKtI3LSeW1aYQ9Zq1NkgeJSTnmMevJvOVrs8LZ9pSOfSi7 qWZQ== X-Gm-Message-State: AOJu0Yx1fz9mvBcHQtdkxpimdB/zt9yJydamlNIr1dmQeRXGTzgGCaKc 72c0L7u5ZyLeL2dStRtZrrOIf4Awz91F4p6VWFdvJg== X-Google-Smtp-Source: AGHT+IGD+xC5FUQR0aTxwMPv6c6iNhhZAJSRChTgz5eHUlKLIvCtloN/M7ERaK959zWo4PmDKX/Ep3jjhb8mQSCpmCk= X-Received: by 2002:a17:906:31c1:b0:993:ffcb:ad4e with SMTP id f1-20020a17090631c100b00993ffcbad4emr8408132ejf.13.1692750424012; Tue, 22 Aug 2023 17:27:04 -0700 (PDT) List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 References: <202211042255.2A4MtqVv032693@gitrepo.freebsd.org> <419530F4-DB8F-46EA-BF45-C130BCF8A3DE@FreeBSD.org> <05979953-C089-4D56-99E3-BBBF066FE277@FreeBSD.org> In-Reply-To: From: Warner Losh Date: Tue, 22 Aug 2023 18:26:52 -0600 Message-ID: Subject: Re: git: 91fcacc35597 - main - if_bnxt: Add support for VLAN on Thor To: Kevin Bowling Cc: Kristof Provost , Sumit Saxena , Warner Losh , "" , "" , src-committers Content-Type: multipart/alternative; boundary="000000000000b795f806038c2b3e" X-Rspamd-Queue-Id: 4RVn8p1jySz4fDm X-Spamd-Bar: ---- X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:2a00:1450::/32, country:US] --000000000000b795f806038c2b3e Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Tue, Aug 22, 2023, 5:59 PM Kevin Bowling wrote: > On Tue, Aug 22, 2023 at 3:39=E2=80=AFPM Kevin Bowling > wrote: > > > > > > > > On Tue, Aug 22, 2023 at 2:07 PM Kristof Provost wrote: > >> > >> On 27 Jun 2023, at 11:17, Kristof Provost wrote: > >> > >> On 4 Nov 2022, at 23:55, Warner Losh wrote: > >> > >> The branch main has been updated by imp: > >> > >> URL: > https://cgit.FreeBSD.org/src/commit/?id=3D91fcacc355971f74aa26fc7861020dc= 3a2a2d717 > >> > >> commit 91fcacc355971f74aa26fc7861020dc3a2a2d717 > >> Author: Sumit Saxena > >> AuthorDate: 2022-11-04 22:24:32 +0000 > >> Commit: Warner Losh > >> CommitDate: 2022-11-04 22:24:32 +0000 > >> > >> if_bnxt: Add support for VLAN on Thor > >> > >> Reviewed by: imp > >> Differential Revision: https://reviews.freebsd.org/D36443 > >> --- > >> sys/dev/bnxt/bnxt.h | 3 +- > >> sys/dev/bnxt/bnxt_hwrm.c | 110 > ++++++++++++++++++++++++++++------------------- > >> sys/dev/bnxt/bnxt_hwrm.h | 7 ++- > >> sys/dev/bnxt/if_bnxt.c | 7 ++- > >> 4 files changed, 74 insertions(+), 53 deletions(-) > >> > >> This commit appears to have broken vlan on these interfaces. > >> My hardware is a Broadcom BCM57416 NetXtreme-E 10GBase-T Ethernet, (in > a Dell T640, if that helps). > >> > >> A simple vlan creation on top of one: > >> ifconfig vlan create > >> ifconfig vlan0 vlan 201 vlandev bnxt0 > >> > >> Results in a loss of connectivity. The kernel logs this, which I assum= e > is related: > >> > >> `bnxt0: HWRM_CFA_L2_FILTER_ALLOC command returned INVALID_PARAMS error= .` > >> > >> After reverting this (and 72e9dbb58cad5262190cf2eae47f764021072128) I > can create vlan interfaces on top of bnxt0 without losing connectivity. > >> > >> > >> Should we revert this before 14.0? > >> > >> There=E2=80=99s also a report of what I think is the same issue in > https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D269133 > >> > >> There=E2=80=99s a proposed patch there, but it did not work for me. > > > > > > In markj=E2=80=99s analysis he mentions the issue of the reinit. > > > > It sounds like there are multiple bugs in this driver but one quick ban= d > aid may be to mark the driver as not needing re-init for VLAN > modifications.. that sounds unlikely and was probably an accident when th= e > if reset functionality was added. You can check e1000 for that. > > Here's what I mean as a patch https://reviews.freebsd.org/D41558 > > > Note I don=E2=80=99t have this hw and haven=E2=80=99t audited the code = so this could be > noise but it=E2=80=99s an easy thing to check. > Is there a good bug we can post that link to for someone to test? Warner > > > >> Best regards, > >> Kristof > --000000000000b795f806038c2b3e Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


On Tue, Aug 22, 2023, 5:59 PM Kevin Bowling <kevin.bowling@kev009.com> wrot= e:
On Tue, Aug 22, 2023 at 3:39=E2= =80=AFPM Kevin Bowling <kevin.bowling@kev009.com> wrote: >
>
>
> On Tue, Aug 22, 2023 at 2:07 PM Kristof Provost <kp@freebsd.org>= wrote:
>>
>> On 27 Jun 2023, at 11:17, Kristof Provost wrote:
>>
>> On 4 Nov 2022, at 23:55, Warner Losh wrote:
>>
>> The branch main has been updated by imp:
>>
>> URL: https://cgit.FreeBSD.org/src/commit/?id=3D91fcacc355971f74aa26fc7861= 020dc3a2a2d717
>>
>> commit 91fcacc355971f74aa26fc7861020dc3a2a2d717
>> Author: Sumit Saxena <sumit.saxena@broadcom.com><= br> >> AuthorDate: 2022-11-04 22:24:32 +0000
>> Commit: Warner Losh <imp@FreeBSD.org>
>> CommitDate: 2022-11-04 22:24:32 +0000
>>
>> if_bnxt: Add support for VLAN on Thor
>>
>> Reviewed by: imp
>> Differential Revision: https://reviews.freebsd= .org/D36443
>> ---
>> sys/dev/bnxt/bnxt.h | 3 +-
>> sys/dev/bnxt/bnxt_hwrm.c | 110 ++++++++++++++++++++++++++++-------= ------------
>> sys/dev/bnxt/bnxt_hwrm.h | 7 ++-
>> sys/dev/bnxt/if_bnxt.c | 7 ++-
>> 4 files changed, 74 insertions(+), 53 deletions(-)
>>
>> This commit appears to have broken vlan on these interfaces.
>> My hardware is a Broadcom BCM57416 NetXtreme-E 10GBase-T Ethernet,= (in a Dell T640, if that helps).
>>
>> A simple vlan creation on top of one:
>> ifconfig vlan create
>> ifconfig vlan0 vlan 201 vlandev bnxt0
>>
>> Results in a loss of connectivity. The kernel logs this, which I a= ssume is related:
>>
>> `bnxt0: HWRM_CFA_L2_FILTER_ALLOC command returned INVALID_PARAMS e= rror.`
>>
>> After reverting this (and 72e9dbb58cad5262190cf2eae47f764021072128= ) I can create vlan interfaces on top of bnxt0 without losing connectivity.=
>>
>>
>> Should we revert this before 14.0?
>>
>> There=E2=80=99s also a report of what I think is the same issue in= https://bugs.freebsd.org/bugzi= lla/show_bug.cgi?id=3D269133
>>
>> There=E2=80=99s a proposed patch there, but it did not work for me= .
>
>
> In markj=E2=80=99s analysis he mentions the issue of the reinit.
>
> It sounds like there are multiple bugs in this driver but one quick ba= nd aid may be to mark the driver as not needing re-init for VLAN modificati= ons.. that sounds unlikely and was probably an accident when the if reset f= unctionality was added.=C2=A0 You can check e1000 for that.

Here's what I mean as a patch https://reviews.freeb= sd.org/D41558

> Note I don=E2=80=99t have this hw and haven=E2=80=99t audited the code= so this could be noise but it=E2=80=99s an easy thing to check.

Is there a = good bug we can post that link to for someone to test?

Warner
>
>> Best regards,
>> Kristof
--000000000000b795f806038c2b3e--