From nobody Tue Apr 28 19:56:38 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4g4rmX5WRyz6c27D for ; Tue, 28 Apr 2026 19:56:44 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R13" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4g4rmX0L55z3G1v for ; Tue, 28 Apr 2026 19:56:44 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1777406204; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=ZRuiVOenumgkolLrD8cox9jFTQQXR43oRI4Ega0LRr4=; b=WbKdkPfdt8iT80Qr6UYfoa4VIu5fu2weULfl8nwBv3Sl4bDsIyHdRjg9WyXSy2brplYcWq kIybV8FWhMnK9hCQR/6uNSBZFmBAizvSXvyV5dWW2/rcFaJh5u2s6gX11tJkrzWGUXdadR aLExqDg4ejykHT3v5tZ1fXaOT2dme5f2T10IiL4g7sWugSeWqyVs32cZjWqPp2pgDwKzon Dcf9mkah2+alzDUNLyvOZlxr+y3eJXagxy1MbzxeWxG8ahFFGpxq+7A7UQD6N23tQwqVZc omslVJqOMlj/awGNHl2B+sbC/bpVsEEEP+xnCFvNhVGjsIuV1FNQWngLBPRC+A== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1777406204; a=rsa-sha256; cv=none; b=T/fi4mWH7gkdXVFoaDzBoPxwvUpUspixkIAbO7123kEXICxgg18LkmVXEJLaxdlehtaoEM LBRkNqozkMLNGoVcotkUIERm3t+baW9/+JTo7zGxuKkNSDXv5dEkVmlGRcP9uChRBoWf5u OVsseZFyRnHkJzykJfEKpipaG2agUpTKGyDTTaqGeCgjgbwtLdF8hmjPHzs5QcBidtWKZ5 kWbXRnLIC/aV3peqNqF9WGo/6huI3W5nlp3b76jgInIHLEsc4N2YXHl7nvBVslyUA+yoWv b1FNnr9S62hLIaAveRV1zOVY77QgengxoYLGGzGky7CLnQ4U//mrtbyFPzyYwQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1777406204; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=ZRuiVOenumgkolLrD8cox9jFTQQXR43oRI4Ega0LRr4=; b=jHLliug77n0nDVJKP9y+GOfEYn8MjDPj9T888lpzPsUHfjZVyNKjv38t3e5bVyYLC2ezR3 gdmugx+RgYusMCbIO8ajgx68PCaMZj+vUsePFATMj43L9VXJOkDghYvLan3y9ZgOHtGa4m 58wARIe4bJY7TZU/y55Oos2JI5PK0n9oPxPJVrH8JirbrILbPLyRfVfjw5R7JBYKw+ERcU AVZoZZ6ExB68O+nolULeCYEWj++VOSZDA3ql0cj58Nl0khuWgM7xzO9UuEopPDOXQGtA0N 7pGHIZUqJf3SsRk/25CYjxW1KAJoiIh+lUwiXKtyvz8vB5mcb2FizNYABv6erA== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4g4rmW6NjJz16wr for ; Tue, 28 Apr 2026 19:56:43 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 365c0 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Tue, 28 Apr 2026 19:56:38 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Lexi Winter Subject: git: 66f55b90b6bc - stable/15 - boot1.chrp: Improve comment for the SLOF hack List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: ivy X-Git-Repository: src X-Git-Refname: refs/heads/stable/15 X-Git-Reftype: branch X-Git-Commit: 66f55b90b6bcbbf3c26b2da7f56d17052e39018f Auto-Submitted: auto-generated Date: Tue, 28 Apr 2026 19:56:38 +0000 Message-Id: <69f110f6.365c0.22666958@gitrepo.freebsd.org> The branch stable/15 has been updated by ivy: URL: https://cgit.FreeBSD.org/src/commit/?id=66f55b90b6bcbbf3c26b2da7f56d17052e39018f commit 66f55b90b6bcbbf3c26b2da7f56d17052e39018f Author: Lexi Winter AuthorDate: 2026-04-17 16:56:33 +0000 Commit: Lexi Winter CommitDate: 2026-04-28 19:56:21 +0000 boot1.chrp: Improve comment for the SLOF hack Since this original comment was written, the actual issue in SLOF was diagnosed and documented in commit 424089a0fc, which fixed it for loader(8). Update the comment in boot1 to be more informative to future readers. MFC after: 3 days Reviewed by: jhibbits, adrian Sponsored by: https://www.patreon.com/bsdivy Differential Revision: https://reviews.freebsd.org/D56470 (cherry picked from commit eb0279550d52962241b4178101cd7f7d732eb682) --- stand/powerpc/boot1.chrp/boot1.c | 13 +++++-------- 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/stand/powerpc/boot1.chrp/boot1.c b/stand/powerpc/boot1.chrp/boot1.c index 1a546f3473e2..1bb06bf82983 100644 --- a/stand/powerpc/boot1.chrp/boot1.c +++ b/stand/powerpc/boot1.chrp/boot1.c @@ -102,14 +102,11 @@ ofwh_t bootdevh; ofwh_t stdinh, stdouth; /* - * Note about the entry point: + * Our entrypoint. * - * For some odd reason, the first page of the load appears to have trouble - * when entering in LE. The first five instructions decode weirdly. - * I suspect it is some cache weirdness between the ELF headers and .text. - * - * Ensure we have a gap between the start of .text and the entry as a - * workaround. + * A bug in the SLOF shipped with some versions of QEMU causes the first + * 32 bytes of .text to be wrongly byte-swapped when loading LE programs. + * As a workaround, we add some padding at the start of the text section. */ __asm(" \n\ .data \n\ @@ -118,7 +115,7 @@ stack: \n\ .space 16384 \n\ \n\ .text \n\ - /* SLOF cache hack */ \n\ + /* SLOF workaround */ \n\ .space 4096 \n\ .globl _start \n\ _start: \n\