From owner-svn-ports-all@FreeBSD.ORG Wed Mar 12 12:39:24 2014 Return-Path: Delivered-To: svn-ports-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 02221937; Wed, 12 Mar 2014 12:39:24 +0000 (UTC) Received: from prod2.absolight.net (mx3.absolight.net [IPv6:2a01:678:2:100::25]) (using TLSv1 with cipher ADH-CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id B344E63F; Wed, 12 Mar 2014 12:39:23 +0000 (UTC) Received: from prod2.absolight.net (localhost [127.0.0.1]) by prod2.absolight.net (Postfix) with ESMTP id 53E80BDC3E; Wed, 12 Mar 2014 13:39:22 +0100 (CET) Received: from gw.in.absolight.net (gw-ecl.in.absolight.net [79.143.241.69]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "gw.in.absolight.net", Issuer "CA Cert Signing Authority" (not verified)) by prod2.absolight.net (Postfix) with ESMTPSA id 4D505BDC2E; Wed, 12 Mar 2014 13:39:22 +0100 (CET) Received: from ogg.in.absolight.net (ogg.in.absolight.net [79.143.241.239]) by gw.in.absolight.net (Postfix) with ESMTP id AF4EC613F; Wed, 12 Mar 2014 13:39:21 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by ogg.in.absolight.net (Postfix) with ESMTP id 487BA6A09B98; Wed, 12 Mar 2014 13:39:21 +0100 (CET) Date: Wed, 12 Mar 2014 13:39:21 +0100 From: Mathieu Arnold To: Tijl Coosemans Subject: Re: svn commit: r347897 - head/devel/git Message-ID: <6405D0DB0BBE9214BFFFE025@ogg.in.absolight.net> In-Reply-To: <20140312124838.4e7fcdea@kalimero.tijl.coosemans.org> References: <201403111758.s2BHwmaJ008196@svn.freebsd.org> <20140312124838.4e7fcdea@kalimero.tijl.coosemans.org> X-Mailer: Mulberry/4.0.8 (Mac OS X) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Content-Disposition: inline Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 12 Mar 2014 12:39:24 -0000 +--On 12 mars 2014 12:48:38 +0100 Tijl Coosemans wrote: | On Wed, 12 Mar 2014 11:09:02 +0100 Mathieu Arnold wrote: |> +--On 11 mars 2014 17:58:48 +0000 Tijl Coosemans |> wrote: |>| Author: tijl |>| Date: Tue Mar 11 17:58:47 2014 |>| New Revision: 347897 |>| URL: http://svnweb.freebsd.org/changeset/ports/347897 |>| QAT: https://qat.redports.org/buildarchive/r347897/ |>| |>| Log: |>| Prevent detection of libcharset.h from converters/libiconv. |>| |>| This forces git to use nl_langinfo() from libc instead of |>| locale_charset() from libiconv. (The latter is practically an alias |>| for the first.) |> |> This need a PORTREVISION bump, doesn't it ? | | I decided not to bump it, but it is an edge case. This commit fixes | a build error on FreeBSD 10 with libiconv installed. When libiconv | is not installed it does not change anything. On FreeBSD 8 and 9 it | does change git to use nl_langinfo() instead of locale_charset() but | these functions are the same and git still links with libiconv for | other functions. So the dependencies stay the same, pkg-plist stays | the same and the overall functionality stays the same. Well, to quote the porter's handbook[1]: PORTREVISION should be increased each time a change is made to the port that changes the generated package in any way. That includes changes that only affect a package built with non-default options. If it's only a build fix, that is, there were no packages with the same version before, it's ok not to bump it, but if it changes the package, any package, it has to be bumped. 1: -- Mathieu Arnold