Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 14 Aug 2021 00:01:51 GMT
From:      Alan Somers <asomers@FreeBSD.org>
To:        src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org
Subject:   git: 825fb07c5598 - main - aio: revert the workaround for bug 251828 in the tests
Message-ID:  <202108140001.17E01pZi099332@gitrepo.freebsd.org>

next in thread | raw e-mail | index | archive | help
The branch main has been updated by asomers:

URL: https://cgit.FreeBSD.org/src/commit/?id=825fb07c55986971b1a20e40a73c12eb0ff432e0

commit 825fb07c55986971b1a20e40a73c12eb0ff432e0
Author:     Alan Somers <asomers@FreeBSD.org>
AuthorDate: 2021-08-13 22:59:10 +0000
Commit:     Alan Somers <asomers@FreeBSD.org>
CommitDate: 2021-08-14 00:01:18 +0000

    aio: revert the workaround for bug 251828 in the tests
    
    This bug is no longer reproducible in 14.0-CURRENT and 13.0-RELEASE
    
    Do not MFC to stable/12 !
    
    PR:             251828
    Reported by:    markj
    Reviewed by:    markj
    MFC after:      2 weeks
    Sponsored by:   Axcient
    Differential Revision: https://reviews.freebsd.org/D31535
---
 tests/sys/aio/aio_test.c | 7 -------
 1 file changed, 7 deletions(-)

diff --git a/tests/sys/aio/aio_test.c b/tests/sys/aio/aio_test.c
index 6681a13653b4..35bd5dc1264b 100644
--- a/tests/sys/aio/aio_test.c
+++ b/tests/sys/aio/aio_test.c
@@ -924,13 +924,6 @@ aio_zvol_setup(void)
 		ZVOL_SIZE " %s", zvol_name);
 	ATF_REQUIRE_EQ_MSG(0, system(cmd),
 	    "zfs create failed: %s", strerror(errno));
-	/*
-	 * XXX Due to bug 251828, we need an extra "zfs set" here
-	 * https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=251828
-	 */
-	snprintf(cmd, sizeof(cmd), "zfs set volmode=dev %s", zvol_name);
-	ATF_REQUIRE_EQ_MSG(0, system(cmd),
-	    "zfs set failed: %s", strerror(errno));
 
 	snprintf(devname, sizeof(devname), "/dev/zvol/%s", zvol_name);
 	do {



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202108140001.17E01pZi099332>