From owner-freebsd-audit  Mon Jul 15  3:21:52 2002
Delivered-To: freebsd-audit@freebsd.org
Received: from mx1.FreeBSD.org (mx1.FreeBSD.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 9588C37B400; Mon, 15 Jul 2002 03:21:50 -0700 (PDT)
Received: from mailman.zeta.org.au (mailman.zeta.org.au [203.26.10.16])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 7CCA743E58; Mon, 15 Jul 2002 03:21:49 -0700 (PDT)
	(envelope-from bde@zeta.org.au)
Received: from bde.zeta.org.au (bde.zeta.org.au [203.2.228.102])
	by mailman.zeta.org.au (8.9.3/8.8.7) with ESMTP id UAA27611;
	Mon, 15 Jul 2002 20:21:44 +1000
Date: Mon, 15 Jul 2002 20:25:13 +1000 (EST)
From: Bruce Evans <bde@zeta.org.au>
X-X-Sender: bde@gamplex.bde.org
To: Dag-Erling Smorgrav <des@ofug.org>
Cc: Giorgos Keramidas <keramida@FreeBSD.ORG>,
	<freebsd-audit@FreeBSD.ORG>
Subject: Re: bin/ln & WARNS=5
In-Reply-To: <xzpele59w21.fsf@flood.ping.uio.no>
Message-ID: <20020715202126.S40071-100000@gamplex.bde.org>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: owner-freebsd-audit@FreeBSD.ORG
Precedence: bulk
List-ID: <freebsd-audit.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20freebsd-audit>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20freebsd-audit>
X-Loop: FreeBSD.ORG

On 15 Jul 2002, Dag-Erling Smorgrav wrote:

> Giorgos Keramidas <keramida@FreeBSD.org> writes:
> > The following allows me to build bin/ln with WARNS=5 on i386.
> > Does it look OK, or have I missed something important?
>
> I'd rather cast sizeof to int.

That would break the possibly-intentional check for snprintf() failing.
(size_t)-1 >= sizeof(path), but !(-1 >= (int)sizeof(path)).

Bruce


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-audit" in the body of the message