From owner-freebsd-gnome@FreeBSD.ORG  Fri Jul 27 15:50:41 2012
Return-Path: <owner-freebsd-gnome@FreeBSD.ORG>
Delivered-To: gnome@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 22A74106566B;
	Fri, 27 Jul 2012 15:50:41 +0000 (UTC)
	(envelope-from mezz.freebsd@gmail.com)
Received: from mail-pb0-f54.google.com (mail-pb0-f54.google.com
	[209.85.160.54])
	by mx1.freebsd.org (Postfix) with ESMTP id DA6738FC0A;
	Fri, 27 Jul 2012 15:50:40 +0000 (UTC)
Received: by pbbro2 with SMTP id ro2so5576875pbb.13
	for <multiple recipients>; Fri, 27 Jul 2012 08:50:40 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
	h=mime-version:in-reply-to:references:date:message-id:subject:from:to
	:cc:content-type;
	bh=CZI5DqtBDC3jB7E3nf779riJYafNxeBagjP3mwCu/jU=;
	b=jwxLPan4kD1hyZ4iEpwESQaJkuhaKvftmfVT+VkwPl14VXoxew3POjMwFf41uyslhd
	Um199XVTghIBaqvDSIG1xztjzXU/RQ1FMNdGhkdiLBFNEIRQrtq4fokPfbqfvfja+ih/
	eNua9KnqBK6/YYzX9D5g0TbP1efv0EFX7VJF7nJoKkV+cYoQbygT0pP3pBKb0iF9hCYQ
	6BBYpvEFyFRwK6MQ3ouZqIPIIY3tP4bDndNEkUIqJgSRoAl+pz0zPYmWfxCmPva5W+2Y
	65pP5nyuHJg9zXyeg/onuc24kfAQTdjl7IERW0ZfmjRBpIUQ07b5eBuPMucwcyfnoYAl
	UtwA==
MIME-Version: 1.0
Received: by 10.68.134.161 with SMTP id pl1mr15164659pbb.29.1343404240465;
	Fri, 27 Jul 2012 08:50:40 -0700 (PDT)
Received: by 10.66.41.100 with HTTP; Fri, 27 Jul 2012 08:50:40 -0700 (PDT)
In-Reply-To: <20120727153119.GE22954@megatron.madpilot.net>
References: <20120727153119.GE22954@megatron.madpilot.net>
Date: Fri, 27 Jul 2012 10:50:40 -0500
Message-ID: <CADLFttda7EPPYS73iQSWxcj8g78G3O7=y0T4uMBdwrjBGQ0d_Q@mail.gmail.com>
From: Jeremy Messenger <mezz.freebsd@gmail.com>
To: Guido Falsi <madpilot@freebsd.org>
Content-Type: text/plain; charset=ISO-8859-1
Cc: gnome@freebsd.org, Chris Rees <crees@freebsd.org>,
	Thomas Abthorpe <tabthorpe@freebsd.org>
Subject: Re: [PATCH] Gnucash port update and fix for pkgconf
X-BeenThere: freebsd-gnome@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: GNOME for FreeBSD -- porting and maintaining
	<freebsd-gnome.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-gnome>,
	<mailto:freebsd-gnome-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-gnome>
List-Post: <mailto:freebsd-gnome@freebsd.org>
List-Help: <mailto:freebsd-gnome-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-gnome>,
	<mailto:freebsd-gnome-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 27 Jul 2012 15:50:41 -0000

On Fri, Jul 27, 2012 at 10:31 AM, Guido Falsi <madpilot@freebsd.org> wrote:
> Hi!
>
> The finance/gnucash port is broken right now.
>
> It contains an improper use of pkg-config which was innocuous, but is
> fatal with pkgconf. It causes an invalid Makefile to be generated by
> configure.
>
> Since a new version is also out I made a patch with a quick and dirty
> fix for the brokenness.
>
> The fix just forces a bogus value in the configure script in place of a
> backtick comamnd. That variable really looks unused anyway by the build
> system. GnuCash builds fine in tinderbox and wiorks correctly on a real
> system with real data.
>
> I'm attaching it requesting approval to commit it.
>
> I also wrote a bug report for this on the gnome bugzilla, waiting
> feedback. ( https://bugzilla.gnome.org/show_bug.cgi?id=680708 )

You have my approval. Yes, it does look like it's just some leftover
and need to be removed. Just let you know about --version can be
changed to --modversion if you find other ports that have like this.
Thanks!

$PKG_CONFIG --version xml

To:

$PKG_CONFIG --modversion libxml-2.0

Cheers,
Mezz


> Thanks in advance!
>
> --
> Guido Falsi <madpilot@FreeBSD.org>


-- 
mezz.freebsd@gmail.com - mezz@FreeBSD.org
FreeBSD GNOME Team
http://www.FreeBSD.org/gnome/ - gnome@FreeBSD.org