Date: Wed, 18 Sep 2019 07:46:11 -0700 From: Enji Cooper <yaneurabeya@gmail.com> To: Kyle Evans <kevans@freebsd.org> Cc: src-committers <src-committers@freebsd.org>, svn-src-all <svn-src-all@freebsd.org>, svn-src-head <svn-src-head@freebsd.org> Subject: Re: svn commit: r352465 - head/share/mk Message-ID: <81382CF5-A928-48EF-93A9-BBBBA174F4BD@gmail.com> In-Reply-To: <CDB9D8B3-4100-4C52-B414-D6C60FE49846@gmail.com> References: <201909180158.x8I1wuZu011258@repo.freebsd.org> <0FBC9A62-AE3B-4F27-AABC-06FF45F415F1@gmail.com> <CACNAnaG23b92BjmAMD_Pn1PW4gcYEne6vdaJ9SuOxHU1hbmyvg@mail.gmail.com> <CDB9D8B3-4100-4C52-B414-D6C60FE49846@gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
> On Sep 18, 2019, at 07:33, Enji Cooper <yaneurabeya@gmail.com> wrote: >=20 >=20 >>> On Sep 18, 2019, at 05:40, Kyle Evans <kevans@freebsd.org> wrote: >>>=20 >>> On Wed, Sep 18, 2019 at 7:34 AM Enji Cooper <yaneurabeya@gmail.com> wrot= e: >>>=20 >>>=20 >>>> On Sep 17, 2019, at 18:58, Kyle Evans <kevans@freebsd.org> wrote: >>>>=20 >>>> Author: kevans >>>> Date: Wed Sep 18 01:58:56 2019 >>>> New Revision: 352465 >>>> URL: https://svnweb.freebsd.org/changeset/base/352465 >>>>=20 >>>> Log: >>>> googletest: default-disable on all of MIPS for now >>>>=20 >>>> Parts of the fusefs tests trigger a bug in current versions of llvm: IR= >>>> representation of some routine for the MIPS targets is a function with a= >>>> large number of arguments. This then leads the compiler on an hour+ lon= g >>>> goose chase, which is OK if you build the current tree but less-so if y= ou're >>>> trying external toolchain or doing a universe build involving mips when= it >>>> eventually gets switched over to LLVM. >>>>=20 >>>> Better, accurate details can be found in LLVM PR43263. >>>=20 >>> Uhhhhh... why not do this in tests/sys/... instead? >>=20 >> Because there's still value in being able to easily enable these for >> building/running the complete set of tests through standard build >> infrastructure, but it's not worth adding a knob specifically for the >> fusefs tests. I also prefer the communication of it being an >> off-by-default option and easily deduced from src.conf(5) that this >> part of the build is default-disabled on mips/mips. >=20 > Let me rephrase things a bit: is googlemock broken for all of mips, or is i= t just the tests? If the latter, the tests should be blacklisted for mips wi= th a justification. If the former, I agree your method of dealing with the s= ituation is ok, but more investigation needs to be done to see whether or no= t the port (in general) is broken and mark it broken if need be. It looks like the latter case, based on the PR, and it=E2=80=99s a build per= formance issue... Is this impacting CI pipelines? > The problem with src.opts.mk=E2=80=99s per-architecture options, is that i= t can be very heavy handed enabling/disabling features. I=E2=80=99m not sure= that everything in there warrants disabling at that level. My investigation suggests that the course of action was overly heavy handed.= While I=E2=80=99m not asking for a revert, it would be really nice if whole= features weren=E2=80=99t disabled, unless there=E2=80=99s an issue with the= feature. Thank you, -Enji=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?81382CF5-A928-48EF-93A9-BBBBA174F4BD>