From owner-freebsd-bugs@FreeBSD.ORG  Fri Mar  1 16:20:01 2013
Return-Path: <owner-freebsd-bugs@FreeBSD.ORG>
Delivered-To: freebsd-bugs@smarthost.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by hub.freebsd.org (Postfix) with ESMTP id D51D2394
 for <freebsd-bugs@smarthost.ysv.freebsd.org>;
 Fri,  1 Mar 2013 16:20:01 +0000 (UTC)
 (envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
 [IPv6:2001:1900:2254:206c::16:87])
 by mx1.freebsd.org (Postfix) with ESMTP id C50467FE
 for <freebsd-bugs@smarthost.ysv.freebsd.org>;
 Fri,  1 Mar 2013 16:20:01 +0000 (UTC)
Received: from freefall.freebsd.org (localhost [127.0.0.1])
 by freefall.freebsd.org (8.14.6/8.14.6) with ESMTP id r21GK12C082529
 for <freebsd-bugs@freefall.freebsd.org>; Fri, 1 Mar 2013 16:20:01 GMT
 (envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
 by freefall.freebsd.org (8.14.6/8.14.6/Submit) id r21GK18s082528;
 Fri, 1 Mar 2013 16:20:01 GMT (envelope-from gnats)
Date: Fri, 1 Mar 2013 16:20:01 GMT
Message-Id: <201303011620.r21GK18s082528@freefall.freebsd.org>
To: freebsd-bugs@FreeBSD.org
Cc: 
From: dfilter@FreeBSD.ORG (dfilter service)
Subject: Re: kern/175648: commit references a PR
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
Reply-To: dfilter service <dfilter@FreeBSD.ORG>
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-bugs>,
 <mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
 <mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 01 Mar 2013 16:20:01 -0000

The following reply was made to PR kern/175648; it has been noted by GNATS.

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: kern/175648: commit references a PR
Date: Fri,  1 Mar 2013 16:19:27 +0000 (UTC)

 Author: jhb
 Date: Fri Mar  1 16:19:09 2013
 New Revision: 247554
 URL: http://svnweb.freebsd.org/changeset/base/247554
 
 Log:
   MFC 246035:
   - Compute the correct size to reallocate when doubling the size of the
     array of loaded objects to avoid a buffer overrun.
   - Use reallocf() to avoid leaking memory if the realloc() fails.
   
   PR:		kern/175648
 
 Modified:
   stable/8/lib/libproc/proc_rtld.c
 Directory Properties:
   stable/8/lib/libproc/   (props changed)
 
 Modified: stable/8/lib/libproc/proc_rtld.c
 ==============================================================================
 --- stable/8/lib/libproc/proc_rtld.c	Fri Mar  1 16:18:40 2013	(r247553)
 +++ stable/8/lib/libproc/proc_rtld.c	Fri Mar  1 16:19:09 2013	(r247554)
 @@ -44,7 +44,8 @@ map_iter(const rd_loadobj_t *lop, void *
  
  	if (phdl->nobjs >= phdl->rdobjsz) {
  		phdl->rdobjsz *= 2;
 -		phdl->rdobjs = realloc(phdl->rdobjs, phdl->rdobjsz);
 +		phdl->rdobjs = reallocf(phdl->rdobjs, sizeof(*phdl->rdobjs) *
 +		    phdl->rdobjsz);
  		if (phdl->rdobjs == NULL)
  			return (-1);
  	}
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"