From owner-svn-src-all@freebsd.org Thu Sep 24 03:08:37 2015 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 5856EA06D67; Thu, 24 Sep 2015 03:08:37 +0000 (UTC) (envelope-from rpaulo@me.com) Received: from mr11p00im-asmtp003.me.com (mr11p00im-asmtp003.me.com [17.110.69.254]) (using TLSv1.2 with cipher DHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 354CB1AE5; Thu, 24 Sep 2015 03:08:37 +0000 (UTC) (envelope-from rpaulo@me.com) MIME-version: 1.0 Content-transfer-encoding: 8BIT Content-type: text/plain; charset=UTF-8 Received: from akita (c-73-162-13-215.hsd1.ca.comcast.net [73.162.13.215]) by mr11p00im-asmtp003.me.com (Oracle Communications Messaging Server 7.0.5.35.0 64bit (built Mar 31 2015)) with ESMTPSA id <0NV500HRIVE2UO30@mr11p00im-asmtp003.me.com>; Thu, 24 Sep 2015 03:08:30 +0000 (GMT) X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2015-09-24_02:,, signatures=0 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 kscore.is_bulkscore=2.22044604925031e-16 compositescore=0.981618935876834 phishscore=0 kscore.is_spamscore=0 rbsscore=0.981618935876834 recipient_to_sender_totalscore=0 spamscore=0 urlsuspectscore=0.981618935876834 adultscore=0 kscore.compositescore=0 circleOfTrustscore=0 suspectscore=0 recipient_domain_to_sender_totalscore=0 bulkscore=0 recipient_domain_to_sender_domain_totalscore=0 recipient_to_sender_domain_totalscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1412110000 definitions=main-1509240055 Message-id: <1443064105.14472.0.camel@me.com> Subject: Re: svn commit: r287934 - head/sys/boot/efi/loader From: Rui Paulo To: Scott Long Cc: Adrian Chadd , jhb@freebsd.org, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Date: Wed, 23 Sep 2015 20:08:25 -0700 In-reply-to: <1F2C327F-433E-4FA6-A083-4565A32C1146@yahoo.com> References: <35a0f1b6-0236-4b0e-b919-00cab07429be@me.com> <1F2C327F-433E-4FA6-A083-4565A32C1146@yahoo.com> X-Mailer: Evolution 3.16.5-1 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 24 Sep 2015 03:08:37 -0000 I gave you feedback: it crashed somewhere else. I haven't had time to work on it. However, go ahead and commit that fix. That code was clearly wrong. On Mon, 2015-09-21 at 23:21 -0700, Scott Long wrote: > As a side note, I’m still waiting for feedback on the patch I sent > you for scsi_sg. I’d like to get this fixed. > > Scott > > > On Sep 21, 2015, at 3:53 PM, Rui Paulo wrote: > > > > No, that doesn't work very well. Not only the modules don't auto > > -load, the way the modules are compiled is different. See, for > > example, cam ctl which doesn't compile the sg code when it's built > > into the kernel, but compiles it when it's built as a module. The > > sg code is currently buggy and causes insta-panics with GNOME 3 > > (perhaps the auto-mounter in hald (?)). > > -- > > Rui Paulo > > > > > > On Sep 21, 2015, at 11:24 AM, Adrian Chadd > > wrote: > > > > > Hi, > > > > > > Warner has been working on the modular kernel thing. But > > > honestly, I > > > think we should just start biting that bullet and ship a modules > > > -only > > > GENERIC by default.. > > > > > > > > > -a > > > > > > > > > On 21 September 2015 at 11:02, Rui Paulo wrote: > > > > So, we're going to keep ignoring the problem and keep patching > > > > things up? > > > > It's a bit sad that a single driver (pmspcv) is able to cause > > > > so much > > > > problems. > > > > > > > > -- > > > > Rui Paulo > > > > > > > > > > > > On Sep 17, 2015, at 01:36 PM, John Baldwin > > > > wrote: > > > > > > > > Author: jhb > > > > Date: Thu Sep 17 20:36:46 2015 > > > > New Revision: 287934 > > > > URL: https://svnweb.freebsd.org/changeset/base/287934 > > > > > > > > > > > > Log: > > > > The EFI boot loader allocates a single chunk of contiguous > > > > memory to > > > > hold the kernel, modules, and any other loaded data. This > > > > memory block > > > > is relocated to the kernel's expected location during the > > > > transfer of > > > > control from the loader to the kernel. > > > > > > > > The GENERIC kernel on amd64 has recently grown such that a > > > > kernel + zfs.ko > > > > no longer fits in the default staging size. Bump the default > > > > size from > > > > 32MB to 48MB to provide more breathing room. > > > > > > > > PR: 201679 > > > > Reviewed by: imp > > > > MFC after: 1 week > > > > Differential Revision: https://reviews.freebsd.org/D3666 > > > > > > > > > > > > Modified: > > > > head/sys/boot/efi/loader/copy.c > > > > > > > > Modified: head/sys/boot/efi/loader/copy.c > > > > =============================================================== > > > > =============== > > > > --- head/sys/boot/efi/loader/copy.c Thu Sep 17 20:36:34 2015 > > > > (r287933) > > > > +++ head/sys/boot/efi/loader/copy.c Thu Sep 17 20:36:46 2015 > > > > (r287934) > > > > @@ -38,7 +38,7 @@ __FBSDID("$FreeBSD$"); > > > > #include > > > > > > > > #ifndef EFI_STAGING_SIZE > > > > -#define EFI_STAGING_SIZE 32 > > > > +#define EFI_STAGING_SIZE 48 > > > > #endif > > > > > > > > #define STAGE_PAGES ((EFI_STAGING_SIZE) * 1024 * 1024 / 4096) > > > > > -- Rui Paulo