Date: Sun, 29 Feb 2004 12:43:37 -0500 (EST) From: Craig Rodrigues <rodrigc@crodrigues.org> To: FreeBSD-gnats-submit@FreeBSD.org Cc: kay_lehmann@web.de Subject: ports/63538: audio/xmms-kj, respect PTHREAD_LIBS Message-ID: <200402291743.i1THhbcp044612@dibbler.crodrigues.org> Resent-Message-ID: <200402291750.i1THoKeJ097993@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 63538
>Category: ports
>Synopsis: audio/xmms-kj, respect PTHREAD_LIBS
>Confidential: no
>Severity: serious
>Priority: medium
>Responsible: freebsd-ports-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: update
>Submitter-Id: current-users
>Arrival-Date: Sun Feb 29 09:50:20 PST 2004
>Closed-Date:
>Last-Modified:
>Originator: Craig Rodrigues
>Release: FreeBSD 5.2-CURRENT i386
>Organization:
>Environment:
System: FreeBSD dibbler.crodrigues.org 5.2-CURRENT FreeBSD 5.2-CURRENT #37
>Description:
audio/xmms-kj does not respect PTHREAD_LIBS. This patch fixes it.
>How-To-Repeat:
>Fix:
Index: Makefile
===================================================================
RCS file: /home/ncvs/ports/audio/xmms-kj/Makefile,v
retrieving revision 1.4
diff -u -r1.4 Makefile
--- Makefile 19 Feb 2004 09:33:38 -0000 1.4
+++ Makefile 29 Feb 2004 17:40:06 -0000
@@ -23,17 +23,19 @@
USE_X_PREFIX= yes
USE_GNOME= gtk12
+USE_REINPLACE= yes
.include <bsd.port.pre.mk>
-.if ${OSVERSION} >= 502102
-FORBIDDEN= "Does not respect PTHREAD_{CFLAGS,LIBS}"
-.endif
+pre-patch:
+ ${REINPLACE_CMD} -e 's/PTHREAD_LIBS/ ${PTHREAD_LIBS}/g' \
+ ${PATCHDIR}/patch-aa
+ ${RM} -f ${PATCHDIR}/*.bak
do-build:
- cd ${WRKSRC} && make
+ cd ${WRKSRC} && $(MAKE)
do-install:
- cd ${WRKSRC} && make install
+ cd ${WRKSRC} && $(MAKE) install
.include <bsd.port.post.mk>
Index: files/patch-aa
===================================================================
RCS file: /home/ncvs/ports/audio/xmms-kj/files/patch-aa,v
retrieving revision 1.2
diff -u -r1.2 patch-aa
--- files/patch-aa 8 Feb 2004 21:58:30 -0000 1.2
+++ files/patch-aa 29 Feb 2004 17:40:06 -0000
@@ -10,7 +10,7 @@
LDFLAGS=-O2
# LIBS=-L/usr/lib `gtk-config --libs` $(LPNG) -lgthread -lpthread -lxmms -Wl,--rpath -Wl,/usr/local/lib
-LIBS=`xmms-config --libs` $(LPNG)
-+LIBS=`xmms-config --libs` $(LPNG) -lc_r
++LIBS=`xmms-config --libs` $(LPNG) PTHREAD_LIBS
OBJS=kj.o resource.o config.o image.o playlist.o
CC=gcc
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200402291743.i1THhbcp044612>