From owner-cvs-all Sat Dec 29 7:57:43 2001 Delivered-To: cvs-all@freebsd.org Received: from mailman.zeta.org.au (mailman.zeta.org.au [203.26.10.16]) by hub.freebsd.org (Postfix) with ESMTP id 8940237B426; Sat, 29 Dec 2001 07:57:37 -0800 (PST) Received: from bde.zeta.org.au (bde.zeta.org.au [203.2.228.102]) by mailman.zeta.org.au (8.9.3/8.8.7) with ESMTP id CAA29056; Sun, 30 Dec 2001 02:57:08 +1100 Date: Sun, 30 Dec 2001 02:56:52 +1100 (EST) From: Bruce Evans X-X-Sender: To: David Malone Cc: "David E. O'Brien" , , Subject: Re: cvs commit: src/share/mk bsd.sys.mk In-Reply-To: <200112291435.aa83853@salmon.maths.tcd.ie> Message-ID: <20011230025454.U405-100000@gamplex.bde.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Sat, 29 Dec 2001, David Malone wrote: > > > WARNS=4 doesn't seem to be the same as WARNS=2 used to be, because > > > -Wno-uninitialized isn't getting added at the end of the warnings > > > flags and so -Wuninitialized is still producing false positives. > > > Could someone review the patch below? > > > Doesn't it work where it already is, since it is to cancel the > > -Wuninitialized provied by -Wall? > > It doesn't seem to work - try setting WARNS=4 and then compiling > usr.bin/getcat. I've just checked and it seems that -W also sets > -Wuninitialised: I suspected that, but checked the man page and it didn't mention it. The code is clearer :-). > Did the patch look OK, or is there some other way I should be doing > this? It's OK. Bruce To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message