From owner-svn-src-all@freebsd.org Wed May 15 08:10:36 2019 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 7340915AF157; Wed, 15 May 2019 08:10:36 +0000 (UTC) (envelope-from kib@freebsd.org) Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id ED5A980CAC; Wed, 15 May 2019 08:10:35 +0000 (UTC) (envelope-from kib@freebsd.org) Received: from tom.home (kib@localhost [127.0.0.1]) by kib.kiev.ua (8.15.2/8.15.2) with ESMTPS id x4F8ARSc016152 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO); Wed, 15 May 2019 11:10:31 +0300 (EEST) (envelope-from kib@freebsd.org) DKIM-Filter: OpenDKIM Filter v2.10.3 kib.kiev.ua x4F8ARSc016152 Received: (from kostik@localhost) by tom.home (8.15.2/8.15.2/Submit) id x4F8AR6p016151; Wed, 15 May 2019 11:10:27 +0300 (EEST) (envelope-from kib@freebsd.org) X-Authentication-Warning: tom.home: kostik set sender to kib@freebsd.org using -f Date: Wed, 15 May 2019 11:10:27 +0300 From: Konstantin Belousov To: Dmitry Chagin Cc: src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r347566 - in head/sys: amd64/amd64 amd64/include dev/cpuctl i386/i386 i386/include x86/include x86/x86 Message-ID: <20190515081027.GL2748@kib.kiev.ua> References: <201905141702.x4EH2LuD061054@repo.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.11.4 (2019-03-13) X-Spam-Status: No, score=-2.9 required=5.0 tests=ALL_TRUSTED,BAYES_00 autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on tom.home X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 15 May 2019 08:10:36 -0000 On Wed, May 15, 2019 at 08:54:04AM +0300, Dmitry Chagin wrote: > вт, 14 мая 2019 г. в 20:02, Konstantin Belousov : > > > Author: kib > > Date: Tue May 14 17:02:20 2019 > > New Revision: 347566 > > URL: https://svnweb.freebsd.org/changeset/base/347566 > > > > Log: > > Mitigations for Microarchitectural Data Sampling. > > > > Microarchitectural buffers on some Intel processors utilizing > > speculative execution may allow a local process to obtain a memory > > disclosure. An attacker may be able to read secret data from the > > kernel or from a process when executing untrusted code (for example, > > in a web browser). > > > > Reference: > > https://www.intel.com/content/www/us/en/security-center/advisory/intel-sa-00233.html > > Security: CVE-2018-12126, CVE-2018-12127, CVE-2018-12130, > > CVE-2019-11091 > > Security: FreeBSD-SA-19:07.mds > > Reviewed by: jhb > > Tested by: emaste, lwhsu > > Approved by: so (gtetlow) > > > > Modified: > > head/sys/amd64/amd64/exception.S > > head/sys/amd64/amd64/genassym.c > > head/sys/amd64/amd64/initcpu.c > > head/sys/amd64/amd64/machdep.c > > head/sys/amd64/amd64/support.S > > > > > > Hi, Kostik! > > cc -target x86_64-unknown-freebsd13.0 > --sysroot=/home/dchagin/obj/home/dchagin/head/amd64.amd64/tmp > -B/home/dchagin/obj/home/dchagin/head/amd64.amd64/tmp/usr/bin -c -x > assembler-with-cpp -DLOCORE -O2 -pipe -fno-strict-aliasing -g -nostdinc > -I. -I/home/dchagin/head/sys -I/home/dchagin/head/sys/contrib/ck/include > -I/home/dchagin/head/sys/contrib/libfdt -D_KERNEL > -DHAVE_KERNEL_OPTION_HEADERS -include opt_global.h > -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer -MD > -MF.depend.support.o -MTsupport.o > -fdebug-prefix-map=./machine=/home/dchagin/head/sys/amd64/include > -fdebug-prefix-map=./x86=/home/dchagin/head/sys/x86/include -mcmodel=kernel > -mno-red-zone -mno-mmx -mno-sse -msoft-float > -fno-asynchronous-unwind-tables -ffreestanding -fwrapv -fstack-protector > -gdwarf-2 -Wall -Wredundant-decls -Wnested-externs -Wstrict-prototypes > -Wmissing-prototypes -Wpointer-arith -Wcast-qual -Wundef -Wno-pointer-sign > -D__printf__=__freebsd_kprintf__ -Wmissing-include-dirs > -fdiagnostics-show-option -Wno-unknown-pragmas > -Wno-error-tautological-compare -Wno-error-empty-body > -Wno-error-parentheses-equality -Wno-error-unused-function > -Wno-error-pointer-sign -Wno-error-shift-negative-value > -Wno-address-of-packed-member -mno-aes -mno-avx -std=iso9899:1999 > -Werror /home/dchagin/head/sys/amd64/amd64/support.S > /home/dchagin/head/sys/amd64/amd64/support.S:1809:2: error: instruction > requires: AVX-512 ISA > vmovdqa64 %zmm0, %gs:0x340 > ^ > /home/dchagin/head/sys/amd64/amd64/support.S:1810:2: error: instruction > requires: AVX-512 ISA > vpxor %zmm0, %zmm0, %zmm0 > ^ > /home/dchagin/head/sys/amd64/amd64/support.S:1813:2: error: instruction > requires: AVX-512 DQ ISA > vorpd (%rdx), %zmm0, %zmm0 > ^ > /home/dchagin/head/sys/amd64/amd64/support.S:1814:2: error: instruction > requires: AVX-512 DQ ISA > vorpd (%rdx), %zmm0, %zmm0 > ^ > /home/dchagin/head/sys/amd64/amd64/support.S:1826:2: error: instruction > requires: AVX-512 ISA > vmovdqa64 %gs:0x340, %zmm0 > ^ > *** Error code 1 > > > I/m missied something? Yes, you are using older compiler than current. Perhaps you are using clang 6.0 still. Update your world. FWIW, this is is reason why the sw sequences use .byte in 11.2/12.0 patches. I do not want to put such abomination into live code base, remembering aesni.ko.