From owner-cvs-all@FreeBSD.ORG Fri Jun 17 18:23:00 2011 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id D8EC01065670; Fri, 17 Jun 2011 18:23:00 +0000 (UTC) (envelope-from sahil@tandon.net) Received: from spartan.hamla.org (spartan.hamla.org [206.251.255.30]) by mx1.freebsd.org (Postfix) with ESMTP id AA6788FC1A; Fri, 17 Jun 2011 18:23:00 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by spartan.hamla.org (Postfix) with ESMTP id 381BA17113; Fri, 17 Jun 2011 14:23:00 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tandon.net; h= date:date:subject:subject:from:from:x-mailer:message-id :content-type:content-type:content-transfer-encoding :mime-version:in-reply-to:references:received:received; s=aegis; t=1308334979; bh=vLFDlJ1hjlrGZ3tglUkyS0wMry7TWu/mkWjJFWQl8xY=; b= HcsYYr+I5VlIMbTYGspPthHAbEzkhIDnOG4lflb/N2T6AIB02h9nPmrDKFmOqZTX HsNMg6JSDdgjKHawtKVkGGwf9fNGroJf1zOtA6OXHaUxuZEYOXcyi5JTXo/E2U7V nGBHCbhuT5U9J6Z4iAc6J5hM2HKZyO8ju2vAuLVhn6k= X-Virus-Scanned: by ClamAV at spartan.hamla.org Received: from spartan.hamla.org ([127.0.0.1]) by localhost (spartan.hamla.org [127.0.0.1]) (amavisd-new, port 10027) with LMTP id XlkZXE4snA+N; Fri, 17 Jun 2011 14:22:59 -0400 (EDT) Received: from [10.123.112.4] (mobile-166-137-138-047.mycingular.net [166.137.138.47]) by spartan.hamla.org (Postfix) with ESMTPSA id 0F01B170F7; Fri, 17 Jun 2011 14:22:58 -0400 (EDT) References: <201106160842.p5G8gS6T054738@repoman.freebsd.org> <20110616164733.GA40181@FreeBSD.org> <20110617004742.GD19139@magic.hamla.org> <0C0893AE-B699-4DAB-AD58-C6075349DC2F@tandon.net> <64E6CAE2-1B3E-4A12-8103-1984DA9BB1E0@tandon.net> In-Reply-To: Mime-Version: 1.0 (iPhone Mail 8C148a) Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii Message-Id: <658B1A13-81D3-4AD5-9303-1EB838C4BDBE@tandon.net> X-Mailer: iPhone Mail (8C148a) From: Sahil Tandon Date: Fri, 17 Jun 2011 14:22:36 -0400 To: "bf1783@gmail.com" Cc: Alexey Dokuchaev , Sahil Tandon , Wen Heping , "cvs-all@freebsd.org" , "ports-committers@freebsd.org" , "cvs-ports@freebsd.org" Subject: Re: cvs commit: ports/sysutils/tmux Makefile X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: **OBSOLETE** CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 17 Jun 2011 18:23:00 -0000 On Jun 17, 2011, at 1:59 PM, "b. f." wrote: > Look, I don't mean to sound overly-exercised about this particular > commit -- that's easy to do in email when there is a lack of other > verbal and non-verbal cues --- of course it doesn't _need_ to be > reverted, although it would be better if it were. Nor did I mean to > suggest that in this particular instance you were arguing for sweeping > changes. I was merely pointing out the flaws in the reasoning behind > the change, and the undesirability of making many such unnecessary ad > hoc changes of this kind over time. The real issue (since this > problem has come up in multiple PRs, and email and forum threads, I > don't enclose it in quotes) is that users (including committers -- the > person who filed the original PR behind this change is a src > committer, and others have made similar mistakes), are being misled by > examples in the base system sources into abuses of __MAKE_CONF, and > are breaking port builds. I have previously suggested adding comments > to /src/share/examples/etc/make.conf to point out this problem, but no > one took up my suggestion, and I can't do it myself because I don't > have a src commit bit. I guess that I'll have to try again. OK; wish you better luck this time, perhaps via someone who lurks in this th= read and has the appropriate bits + shares your motivation.=