Date: Fri, 17 Jun 2011 14:22:36 -0400 From: Sahil Tandon <sahil@tandon.net> To: "bf1783@gmail.com" <bf1783@gmail.com> Cc: Alexey Dokuchaev <danfe@freebsd.org>, Sahil Tandon <sahil@freebsd.org>, Wen Heping <wen@freebsd.org>, "cvs-all@freebsd.org" <cvs-all@freebsd.org>, "ports-committers@freebsd.org" <ports-committers@freebsd.org>, "cvs-ports@freebsd.org" <cvs-ports@freebsd.org> Subject: Re: cvs commit: ports/sysutils/tmux Makefile Message-ID: <658B1A13-81D3-4AD5-9303-1EB838C4BDBE@tandon.net> In-Reply-To: <BANLkTimHVy6W=Hy4C2J2mLvkXeV4oweopA@mail.gmail.com> References: <201106160842.p5G8gS6T054738@repoman.freebsd.org> <20110616164733.GA40181@FreeBSD.org> <20110617004742.GD19139@magic.hamla.org> <BANLkTik344RMoiKtSejSxmEa14WNAR1x4Q@mail.gmail.com> <0C0893AE-B699-4DAB-AD58-C6075349DC2F@tandon.net> <BANLkTinsy9QqgFJ7kBHfMsQ77OnohM0O2w@mail.gmail.com> <64E6CAE2-1B3E-4A12-8103-1984DA9BB1E0@tandon.net> <BANLkTimHVy6W=Hy4C2J2mLvkXeV4oweopA@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Jun 17, 2011, at 1:59 PM, "b. f." <bf1783@googlemail.com> wrote: > Look, I don't mean to sound overly-exercised about this particular > commit -- that's easy to do in email when there is a lack of other > verbal and non-verbal cues --- of course it doesn't _need_ to be > reverted, although it would be better if it were. Nor did I mean to > suggest that in this particular instance you were arguing for sweeping > changes. I was merely pointing out the flaws in the reasoning behind > the change, and the undesirability of making many such unnecessary ad > hoc changes of this kind over time. The real issue (since this > problem has come up in multiple PRs, and email and forum threads, I > don't enclose it in quotes) is that users (including committers -- the > person who filed the original PR behind this change is a src > committer, and others have made similar mistakes), are being misled by > examples in the base system sources into abuses of __MAKE_CONF, and > are breaking port builds. I have previously suggested adding comments > to /src/share/examples/etc/make.conf to point out this problem, but no > one took up my suggestion, and I can't do it myself because I don't > have a src commit bit. I guess that I'll have to try again. OK; wish you better luck this time, perhaps via someone who lurks in this th= read and has the appropriate bits + shares your motivation.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?658B1A13-81D3-4AD5-9303-1EB838C4BDBE>