From owner-freebsd-bugs  Mon May 12 21:01:39 1997
Return-Path: <owner-bugs>
Received: (from root@localhost)
          by hub.freebsd.org (8.8.5/8.8.5) id VAA27152
          for bugs-outgoing; Mon, 12 May 1997 21:01:39 -0700 (PDT)
Received: from implode.root.com (implode.root.com [198.145.90.17])
          by hub.freebsd.org (8.8.5/8.8.5) with ESMTP id VAA27145
          for <freebsd-bugs@hub.freebsd.org>; Mon, 12 May 1997 21:01:37 -0700 (PDT)
Received: from localhost (localhost [127.0.0.1])
	by implode.root.com (8.8.5/8.8.5) with SMTP id VAA11983;
	Mon, 12 May 1997 21:00:43 -0700 (PDT)
Message-Id: <199705130400.VAA11983@implode.root.com>
X-Authentication-Warning: implode.root.com: localhost [127.0.0.1] didn't use HELO protocol
To: Bruce Evans <bde@zeta.org.au>
cc: freebsd-bugs@hub.freebsd.org
Subject: Re: kern/3584: small cleanup to tcp_input.c 
In-reply-to: Your message of "Mon, 12 May 1997 20:00:01 PDT."
             <199705130300.UAA24238@hub.freebsd.org> 
From: David Greenman <dg@root.com>
Reply-To: dg@root.com
Date: Mon, 12 May 1997 21:00:42 -0700
Sender: owner-bugs@FreeBSD.ORG
X-Loop: FreeBSD.org
Precedence: bulk

>The following reply was made to PR kern/3584; it has been noted by GNATS.
>
>From: Bruce Evans <bde@zeta.org.au>
>To: FreeBSD-gnats-submit@freebsd.org, luigi@iet.unipi.it
>Cc:  Subject: Re: kern/3584: small cleanup to tcp_input.c
>Date: Tue, 13 May 1997 12:54:55 +1000
>
> >	The TCP_REASS macro is defined two times, depending on the
> >	value of TCP_ACK_HACK. Since the macro is quite long, I think
> >	this definition is preferable
> 
> Fine.
> 
> >       (and consistent with the
> >	convention for multiline macros in style(9) ).
> 
> Aligned backslashes may be easier to read, but they are Kernal Abnormal
> Form, especially in network code (see mbuf.h).

   Actually, I think TCP_ACK_HACK should just be killed altogether. It's
a creation of mine that needs to die.

-DG

David Greenman
Core-team/Principal Architect, The FreeBSD Project