From owner-p4-projects@FreeBSD.ORG Sat Dec 27 22:02:29 2008 Return-Path: Delivered-To: p4-projects@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 32767) id 0A77C1065676; Sat, 27 Dec 2008 22:02:29 +0000 (UTC) Delivered-To: perforce@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id C32241065673 for ; Sat, 27 Dec 2008 22:02:28 +0000 (UTC) (envelope-from ed@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id B42728FC14 for ; Sat, 27 Dec 2008 22:02:28 +0000 (UTC) (envelope-from ed@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.3/8.14.3) with ESMTP id mBRM2Sd0016698 for ; Sat, 27 Dec 2008 22:02:28 GMT (envelope-from ed@FreeBSD.org) Received: (from perforce@localhost) by repoman.freebsd.org (8.14.3/8.14.3/Submit) id mBRM2Sxh016696 for perforce@freebsd.org; Sat, 27 Dec 2008 22:02:28 GMT (envelope-from ed@FreeBSD.org) Date: Sat, 27 Dec 2008 22:02:28 GMT Message-Id: <200812272202.mBRM2Sxh016696@repoman.freebsd.org> X-Authentication-Warning: repoman.freebsd.org: perforce set sender to ed@FreeBSD.org using -f From: Ed Schouten To: Perforce Change Reviews Cc: Subject: PERFORCE change 155349 for review X-BeenThere: p4-projects@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: p4 projects tree changes List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 27 Dec 2008 22:02:29 -0000 http://perforce.freebsd.org/chv.cgi?CH=155349 Change 155349 by ed@ed_dull on 2008/12/27 22:01:52 Really fix the crash in do_scroll(). It seems I didn't properly review the changes to scrolling up. Affected files ... .. //depot/projects/mpsafetty/sys/dev/syscons/teken/teken_subr.h#22 edit Differences ... ==== //depot/projects/mpsafetty/sys/dev/syscons/teken/teken_subr.h#22 (text+ko) ==== @@ -105,13 +105,12 @@ tp.tp_col = 0; teken_funcs_copy(t, &tr, &tp); - tr.tr_end.tp_row = t->t_scrollreg.ts_end - amount; + tr.tr_begin.tp_row = t->t_scrollreg.ts_end - amount; } else { - tr.tr_end.tp_row = t->t_scrollreg.ts_begin; + tr.tr_begin.tp_row = t->t_scrollreg.ts_begin; } /* Clear the last lines. */ - tr.tr_begin.tp_row = t->t_scrollreg.ts_end - amount; tr.tr_begin.tp_col = 0; tr.tr_end.tp_row = t->t_scrollreg.ts_end; tr.tr_end.tp_col = t->t_winsize.tp_col;