Date: Fri, 12 Aug 2005 14:15:51 +0200 From: Christian Brueffer <chris@unixpages.org> To: John Baldwin <jhb@FreeBSD.org> Cc: FreeBSD current mailing list <current@FreeBSD.org> Subject: Re: Locking fixes for sf(4) Message-ID: <20050812121551.GA888@unixpages.org> In-Reply-To: <200508111124.11582.jhb@FreeBSD.org> References: <200508101658.09719.jhb@FreeBSD.org> <20050811150052.GA917@unixpages.org> <200508111124.11582.jhb@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--6TrnltStXW4iwmi0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Aug 11, 2005 at 11:24:10AM -0400, John Baldwin wrote: > On Thursday 11 August 2005 11:00 am, Christian Brueffer wrote: > > On Wed, Aug 10, 2005 at 04:58:09PM -0400, John Baldwin wrote: > > > I've fixed up the locking in sf(4) but do not have the hardware to te= st > > > the changes. Can someone please test these patches? Thanks. > > > > > > http://www.freebsd.org/~jhb/patches/sf_locking.patch > > > > Results in a "recursed on non-recursive mutex" panic. Unfortunately > > the dump looks busted, I'll get a good one tomorrow (can also test the > > my(4) patch then). >=20 > Ok. If you could just get the backtrace from ddb that would probably be= =20 > sufficient. Thanks for testing! >=20 panic: _mtx_lock_sleep: recursed on non-recursive mutex sf0 @ /usr/home/build/src/sys/modules/sf/.. /../pci/if_sf.c:477 CPUID =3D 1 KDB: enter: panic [thread pid 220 tid 100072 ] Stopped at kdb_enter+0x30: leave db> tr Tracing pid 220 tid 100072 td 0xc1d63480 kdb_enter(c079421b,1,c0793681,d8945ab4,c1d63480) at kdb_enter+0x30 panic(c0793681,c1ad6ab0,c08ed18a,1dd,1dd) at panic+0x14e _mtx_lock_sleep(c1ac3c4c,c1d63480,0,c08ed18a,1dd) at _mtx_lock_sleep+0x47 _mtx_lock_flags(c1ac3c4c,0,c08ed18a,1dd,0) at _mtx_lock_flags+0x9c sf_ifmedia_upd(c1adb800,1000,c08ed18a,4b7,c1ac3c4c) at sf_ifmedia_upd+0x3e sf_init_locked(c1ac3c4c,0,c08ed18a,4aa,c1adb800) at sf_init_locked+0x4bc sf_init(c1ac3c00,740,c07a8534,8020690c,c1ac3c00) at sf_init+0x39 ether_ioctl(c1adb800,8020690c,c1d67e00,c05a7cd1,0) at ether_ioctl+0x67 sf_ioctl(c1adb800,8020690c,c1d67e00,100,1) at sf_ioctl+0xbb in_ifinit(c1adb800,c1d67e00,c1cef3d0,0,1) at in_ifinit+0x208 in_control(c1dfcde8,8040691a,c1cef3c0,c1adb800,c1d63480) at in_control+0x986 ifioctl(c1dfcde8,8040691a,c1cef3c0,c1d63480,2) at ifioctl+0x1cd soo_ioctl(c1d59d80,8040691a,c1cef3c0,c19dca80,c1d63480) at soo_ioctl+0x3ef ioctl(c1d63480,d8945d04,c,422,3) at ioctl+0x45d syscall(3b,3b,3b,80beac0,1) at syscall+0x2c0 Xint0x80_syscall() at Xint0x80_syscall+0x1f --- syscall (54, FreeBSD ELF32, ioctl), eip =3D 0x8055473, esp =3D 0xbfbfe5= fc, ebp =3D 0xbfbfee68 --- - Christian --=20 Christian Brueffer chris@unixpages.org brueffer@FreeBSD.org GPG Key: http://people.freebsd.org/~brueffer/brueffer.key.asc GPG Fingerprint: A5C8 2099 19FF AACA F41B B29B 6C76 178C A0ED 982D --6TrnltStXW4iwmi0 Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.6 (FreeBSD) iD8DBQFC/JL3bHYXjKDtmC0RAnX4AJ9pUpyC6QnVvG/W8GSE4qt5KurMrACgsqwF uzGZWzPcGYQJIlbp2QYHOP4= =alC4 -----END PGP SIGNATURE----- --6TrnltStXW4iwmi0--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20050812121551.GA888>