From owner-freebsd-current Mon Jul 5 11:12:33 1999 Delivered-To: freebsd-current@freebsd.org Received: from mail.HiWAAY.net (fly.HiWAAY.net [208.147.154.56]) by hub.freebsd.org (Postfix) with ESMTP id BE75E14C3D for ; Mon, 5 Jul 1999 11:12:31 -0700 (PDT) (envelope-from sprice@hiwaay.net) Received: from localhost (sprice@localhost) by mail.HiWAAY.net (8.9.1a/8.9.0) with ESMTP id NAA21481; Mon, 5 Jul 1999 13:12:29 -0500 (CDT) Date: Mon, 5 Jul 1999 13:12:28 -0500 (CDT) From: Steve Price To: Parag Patel Cc: freebsd-current@FreeBSD.ORG Subject: Re: alpha kernel build failure (w/patch) In-Reply-To: <64807.931197577@pinhead.parag.codegen.com> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG [trimmed -alpha from cc: list to keep the cross posting police from coming after me :)] On Mon, 5 Jul 1999, Parag Patel wrote: # On Mon, 05 Jul 1999 00:33:57 CDT, Steve Price wrote: # >+#ifdef __i386__ # > sc->wb_btag = I386_BUS_SPACE_IO; # >+#endif # >+#ifdef __alpha__ # >+ sc->wb_btag = ALPHA_BUS_SPACE_IO; # >+#endif # # Just curious, but is there a reason that these lines aren't simply # # sc->wb_btag = BUS_SPACE_IO; # # with this macro being set to the correct machine-specific one in some # appropriate header file? I'm sure I'm missing something... I wondered that as well. For both the i386 and alpha port the definitions end up in /usr/include/machine/bus.h and stripping off the arch-specific prefix shows that their value is the same. In fact they appear to be the only #define in bus.h with the arch-specific prefix besides the multiple-inclusion #defines. I think they could be combined, but defer the decision (commit) to the folks working on the new bus code as they know their way around this code much better than I do. -steve To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message