Date: Mon, 30 Jan 2006 10:45:18 +0100 From: Jean-Yves Lefort <jylefort@FreeBSD.org> To: Alexander Leidinger <Alexander@Leidinger.net> Cc: ports@FreeBSD.org, mezz@FreeBSD.org, ru@FreeBSD.org, kris@obsecurity.org Subject: Re: Flaw in print/acroread7 (was: Re: [ru@FreeBSD.org: [patch] mixed i386/amd64 ports semi-broken]) Message-ID: <20060130104518.09ad976a.jylefort@FreeBSD.org> In-Reply-To: <20060130102337.azmqgbcstcksgo88@netchild.homeip.net> References: <20060129185239.GC83362@ip.net.ua> <20060129221019.1c0a5d10@Magellan.Leidinger.net> <20060130040847.2ee8891f.jylefort@FreeBSD.org> <20060130031719.GA22430@xor.obsecurity.org> <20060130050239.485d2547.jylefort@FreeBSD.org> <20060130055838.GA24139@xor.obsecurity.org> <20060130071841.4aed92a2.jylefort@FreeBSD.org> <20060130065505.GA24898@xor.obsecurity.org> <20060130102337.azmqgbcstcksgo88@netchild.homeip.net>
next in thread | previous in thread | raw e-mail | index | archive | help
--Signature=_Mon__30_Jan_2006_10_45_18_+0100_d+bGL4XDZ1L.k=Fl
Content-Type: text/plain; charset=US-ASCII
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
On Mon, 30 Jan 2006 10:23:37 +0100
Alexander Leidinger <Alexander@Leidinger.net> wrote:
> Kris Kennaway <kris@obsecurity.org> wrote:
>=20
> >> But since it
> >> passes ARCH as a make argument, it breaks things such as:
> >>
> >> .if (${ARCH} =3D=3D "amd64")
> >> ARCH=3D i386
> >> RPMFLAGS+=3D --ignorearch
> >> .endif
> >
> > How many ports do that?
>=20
> Nearly every linux port which is known to work on amd64 does something li=
ke
> this.
>=20
> >> because the ARCH=3Di386 assignment is overriden by the ARCH passed on
> >> the submake command line. Removing ARCH from .MAKEFLAGS should fix the
> >> issue without breaking ports.
> >
> > Perhaps you can just do the same thing, and pass in the new ARCH to
> > the port build as a make argument.
>=20
> I want to highlight the fact, that the current way of doing it highlighted
> the "bug" that acroread7 isn't "certified" for the use on amd64. Someone =
has
> to handle the ARCH part in the acroread port as other linux-XXX ports on
> amd64 handle this. If it works on amd64, a committer who isn't bored to
> interact with Trevor should then commit this "certification" (it's just
> setting ARCH to i386 in the amd64 case).
>
> Are there other ports which are affected by this? If yes, how many of them
> are not linux ports?
>=20
> I only expect linux ports to be affected by the current way of handling A=
RCH
> in bsd.port.mk. And they are affected by this, because nobody cared to te=
st
> them in the appropriate way on amd64 and commit/submit the "blessing" for
> amd64.
It's not a bug in acroread7. It's a bug in bpm which causes ARCH to be
read-only in submakes, or it's a bug in the ports which try to
override ARCH without success since it's read-only in submakes;
someone should decide.
--=20
Jean-Yves Lefort
jylefort@FreeBSD.org
http://lefort.be.eu.org/
--Signature=_Mon__30_Jan_2006_10_45_18_+0100_d+bGL4XDZ1L.k=Fl
Content-Type: application/pgp-signature
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.2 (FreeBSD)
iD8DBQFD3eA0yzD7UaO4AGoRAuTPAJ9bxt53mWZphnm2mSwvN8QiRMjNKwCdGlwp
VWwNdCN5pKz/rdZuwkHfkh4=
=Y+wD
-----END PGP SIGNATURE-----
--Signature=_Mon__30_Jan_2006_10_45_18_+0100_d+bGL4XDZ1L.k=Fl--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20060130104518.09ad976a.jylefort>