From owner-freebsd-net@FreeBSD.ORG  Tue Mar 18 11:44:01 2014
Return-Path: <owner-freebsd-net@FreeBSD.ORG>
Delivered-To: net@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id B5DF4F7B
 for <net@freebsd.org>; Tue, 18 Mar 2014 11:44:01 +0000 (UTC)
Received: from mail-qc0-x22b.google.com (mail-qc0-x22b.google.com
 [IPv6:2607:f8b0:400d:c01::22b])
 (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits))
 (No client certificate requested)
 by mx1.freebsd.org (Postfix) with ESMTPS id 78925275
 for <net@freebsd.org>; Tue, 18 Mar 2014 11:44:01 +0000 (UTC)
Received: by mail-qc0-f171.google.com with SMTP id c9so1709987qcz.30
 for <net@freebsd.org>; Tue, 18 Mar 2014 04:44:00 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
 h=mime-version:sender:in-reply-to:references:date:message-id:subject
 :from:to:cc:content-type;
 bh=ljcZ16yVhEe6EOGOofFP1YyW63KoCEZ4Ob8KKJeImW8=;
 b=UYBgbOjclo1TapwCnRFvok4Y5wbOmKCmnhA5ekkSRfSNQEersCI+trRl+66bzlyp0V
 AO7cFeGYQMGqu8SkqInZ+NECGXFVQvksQBb84Z2rXs3/aCQyp//zbIyrxNj0bD0b6X+C
 MtC5oBShst5+8doqbkCWzaObkqqHphUwNNCrTThNz6sapwbUecqr17g4SOkjED5ktDnx
 lAT6hEqjGp/Z2lAkFVThumSQ4aYcz86cTfBE8LPNH36yPRgINFST+ITC4YxiUyGcRA1Q
 /ne2E1txJPwzn/XkMDSywUE+xFyYB0/JoIPEdxaFcQEDAThqryJ9xkS/1J05nbGTwgtj
 lCWg==
MIME-Version: 1.0
X-Received: by 10.140.50.169 with SMTP id s38mr33061253qga.12.1395143040700;
 Tue, 18 Mar 2014 04:44:00 -0700 (PDT)
Sender: adrian.chadd@gmail.com
Received: by 10.224.8.137 with HTTP; Tue, 18 Mar 2014 04:44:00 -0700 (PDT)
In-Reply-To: <53280DB3.4080900@oktetlabs.ru>
References: <53280DB3.4080900@oktetlabs.ru>
Date: Tue, 18 Mar 2014 04:44:00 -0700
X-Google-Sender-Auth: Xw2xnxzTM5RUTWOnAwHN5pW8SgI
Message-ID: <CAJ-VmomkRXKauiDm4OKuiYbQYH8GdnJb8xHNfRzzNeJ7NpoDKQ@mail.gmail.com>
Subject: Re: [PATCH 1/6] sfxge: fix mbuf leak if it does not fit in software
 queue
From: Adrian Chadd <adrian@freebsd.org>
To: Andrew Rybchenko <Andrew.Rybchenko@oktetlabs.ru>
Content-Type: text/plain; charset=ISO-8859-1
Cc: "net@freebsd.org" <net@freebsd.org>
X-BeenThere: freebsd-net@freebsd.org
X-Mailman-Version: 2.1.17
Precedence: list
List-Id: Networking and TCP/IP with FreeBSD <freebsd-net.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-net>,
 <mailto:freebsd-net-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-net/>
List-Post: <mailto:freebsd-net@freebsd.org>
List-Help: <mailto:freebsd-net-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
 <mailto:freebsd-net-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 18 Mar 2014 11:44:01 -0000

Hi!

Who's the solarflare driver maintainer?

Ah, there isn't one. The closest is Ben Hutchings <bwh@solarflare.com>.

I can commit these if no-one else is willing but I don't have any
solarflare hardware to test it on.


-a


On 18 March 2014 02:11, Andrew Rybchenko <Andrew.Rybchenko@oktetlabs.ru> wrote:
>
> sfxge: fix mbuf leak if it does not fit in software queue
>
> mbuf should be owned by if_transmit function in any case.
>
> Submitted-by:   Andrew Rybchenko <Andrew.Rybchenko@oktetlabs.ru>
> Sponsored by:   Solarflare Communications, Inc.
>
> diff -r e2bc8f64f1b2 -r ff9f5d3dbafe src/driver/freebsd/sfxge_tx.c
> --- a/head/sys/dev/sfxge/sfxge_tx.c    Tue Mar 04 13:13:05 2014 +0400
> +++ b/head/sys/dev/sfxge/sfxge_tx.c    Tue Mar 04 13:15:13 2014 +0400
> @@ -536,6 +536,7 @@
>      return (0);
>
>  fail:
> +    m_freem(m);
>      return (rc);
>
>  }
>
> _______________________________________________
> freebsd-net@freebsd.org mailing list
> http://lists.freebsd.org/mailman/listinfo/freebsd-net
> To unsubscribe, send any mail to "freebsd-net-unsubscribe@freebsd.org"