From owner-svn-ports-head@FreeBSD.ORG  Tue Nov 26 07:51:22 2013
Return-Path: <owner-svn-ports-head@FreeBSD.ORG>
Delivered-To: svn-ports-head@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 1033)
 id AD1117E9; Tue, 26 Nov 2013 07:51:22 +0000 (UTC)
Date: Tue, 26 Nov 2013 07:51:22 +0000
From: Alexey Dokuchaev <danfe@FreeBSD.org>
To: Baptiste Daroussin <bapt@FreeBSD.org>
Subject: Re: svn commit: r334593 - in head/dns: bind96 bind96/files bind98
 bind98/files bind99 bind99/files
Message-ID: <20131126075122.GA88351@FreeBSD.org>
References: <201311221341.rAMDfY3g002148@svn.freebsd.org>
 <01490d316b5dd7f01f1c843871542666@secure.marino.st>
 <2DEEB271-4795-4DF0-8F85-30316BA3070F@FreeBSD.org>
 <5291C8BD.3070109@marino.st> <20131126035339.GA43389@FreeBSD.org>
 <20131126073851.GE19582@ithaqua.etoilebsd.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20131126073851.GE19582@ithaqua.etoilebsd.net>
User-Agent: Mutt/1.5.22 (2013-10-16)
Cc: svn-ports-head@freebsd.org, owner-ports-committers@freebsd.org,
 svn-ports-all@freebsd.org, marino@freebsd.org, ports-committers@freebsd.org,
 Erwin Lansing <erwin@FreeBSD.org>
X-BeenThere: svn-ports-head@freebsd.org
X-Mailman-Version: 2.1.16
Precedence: list
List-Id: SVN commit messages for the ports tree for head
 <svn-ports-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-head/>
List-Post: <mailto:svn-ports-head@freebsd.org>
List-Help: <mailto:svn-ports-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 26 Nov 2013 07:51:22 -0000

On Tue, Nov 26, 2013 at 08:38:52AM +0100, Baptiste Daroussin wrote:
> On Tue, Nov 26, 2013 at 03:53:39AM +0000, Alexey Dokuchaev wrote:
> > Given that OSVERSION is used extensively in the tree, I'm worrying that
> > adding these extra "${OPSYS} == FreeBSD" checks will our makefiles less
> > readable.  Wouldn't it make more sense to place this check somewhere in
> > single place, and define whatever OSVERSION that looks reasonable when
> > OPSYS == FreeBSD instead of patching every port?
> 
> except that lots/most of the osversion checking in the ports tree is also
> wrong and was due to a design bug of pointyhat/tinderbox, pointyhat is gone,
> and tinderbox had been fixed. there is no need anymore for most of them
> which also are often wrong given the flexibility we have with buildworld.
> 
> I do plan to remove most of the useless osversion.

Yup, I remember this was discussed on IRC a few times.  I'm only looking
forward to it.  However, introducing "${OPSYS} == FreeBSD" checks in, uhm,
*FreeBSD* ports collection looks bogus to me.  If <whatever>BSD wants to
make use of it, fine, but please let's keep their little hacks outside of
FreeBSD ports. :)

./danfe