From owner-freebsd-stable@FreeBSD.ORG Mon Jan 22 18:34:50 2007 Return-Path: X-Original-To: freebsd-stable@freebsd.org Delivered-To: freebsd-stable@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 64A8316A40A for ; Mon, 22 Jan 2007 18:34:50 +0000 (UTC) (envelope-from jfvogel@gmail.com) Received: from ug-out-1314.google.com (ug-out-1314.google.com [66.249.92.169]) by mx1.freebsd.org (Postfix) with ESMTP id C6CF913C4D9 for ; Mon, 22 Jan 2007 18:34:49 +0000 (UTC) (envelope-from jfvogel@gmail.com) Received: by ug-out-1314.google.com with SMTP id o2so1049737uge for ; Mon, 22 Jan 2007 10:34:48 -0800 (PST) DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=beta; h=received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=X4gBLCTQlvA0X33liZitVbnSrcmGLO0ckIjzW76tW9ed/6lwKDkxvssPMn4ieRFs29qRi0BVOkVuHlkqwIda1UqD8MFG41jCw1S3j3wTXRUD7j/0YaQKuKyP3gUq7b+x/kR7eb9d3lVSEZGNkIdu/8S0reeG/h8QGJ78ZFm5eZI= Received: by 10.82.138.6 with SMTP id l6mr5620904bud.1169490888138; Mon, 22 Jan 2007 10:34:48 -0800 (PST) Received: by 10.82.127.12 with HTTP; Mon, 22 Jan 2007 10:34:48 -0800 (PST) Message-ID: <2a41acea0701221034j42fed2a9g3934ef187e3964ca@mail.gmail.com> Date: Mon, 22 Jan 2007 10:34:48 -0800 From: "Jack Vogel" To: "Gleb Smirnoff" In-Reply-To: <2a41acea0701221030x52dd8821pd858ae7e6740ce92@mail.gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <2a41acea0701171258k16b4c6ebuf1d4794b89d0749b@mail.gmail.com> <20070120065321.DB61216A405@hub.freebsd.org> <2a41acea0701201435g6f960b40r3cf0552d87ab2bfd@mail.gmail.com> <20070122083506.GW4485@FreeBSD.org> <2a41acea0701221030x52dd8821pd858ae7e6740ce92@mail.gmail.com> Cc: Bill Paul , freebsd-current@freebsd.org, freebsd-stable@freebsd.org, jon.otterholm@ide.resurscentrum.se Subject: Re: Lenovo X60 em workaround X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 22 Jan 2007 18:34:50 -0000 On 1/22/07, Jack Vogel wrote: > On 1/22/07, Gleb Smirnoff wrote: > > Jack, > > > > On Sat, Jan 20, 2007 at 02:35:17PM -0800, Jack Vogel wrote: > > J> >> Since this was just seen, and the patch below validated as working I > > J> >wanted > > J> >> to send general email to capture this: > > J> >> > > J> >> The Lenovo X60 can have issues with long ping times, this is a KNOWN > > J> >> hardware problem, and Intel is working with IBM/Lenovo, a final 'fix' has > > J> >> not been decided on yet. Nevertheless, the patch below will work, but > > J> >> I do not want to check it in as its still temporary. > > J> >> > > J> >> Address questions to me, > > J> > > > J> >Okay, I have a question. Could you elaborate on just what the problem is? > > J> >(I mean, since it's KNOWN and all...) I'm just having a hard time figuring > > J> >out what problem could possibly be fixed by setting the RX interrupt > > J> >delay timer to a non-zero value (especially since elsewhere in the em(4) > > J> >source it says that doing so is a Bad Thing (tm)). > > J> > > J> saying its known to be a problem doesnt mean its cause is known :) > > J> They discovered that setting this eliminated the problem, but we > > J> immediately pointed out that this is, as you pointed out, a Bad > > J> Thing on other hardware, so the investigation continues, there is > > J> always a communication lag on these kind of things, so I dont know > > J> if it has been resolved yet or not. > > J> > > J> I just dont think this patch will become the final way to solve this, > > J> but we shall see :) > > > > Good to know that there is progress on this. Thanks! I will try the patch > > on my Lenovo T60 notebook, where the problem is also present. AFAIK, it > > is present on any Lenovo notebook with 82573 NIC. > > > > Can you please acknowledge that another bug with Lenovo + em(4) is known? I > > mean the problem, that em(4) isn't initialized properly on kernel boot, if > > the link is down. I have already reported this to you, and you said that > > I probably have bad hardware. Since that time, I've found several similar > > reports about Lenovo notebooks and em(4) driver in FreeBSD. > > Hey Gleb, > > Acknowledge... I can do better than that, I have a fix for this problem, and > its not temporary. Here is the code change (not a patch, I'm very busy), > its in hardware_init, should be obvious how to patch: > > /* Make sure we have a good EEPROM before we read from it */ > if (e1000_validate_nvm_checksum(&adapter->hw) < 0) { > /* > ** Some PCI-E parts fail the first check due to > ** the link being in sleep state, call it again, > ** if it fails a second time its a real issue. > */ > if (e1000_validate_nvm_checksum(&adapter->hw) < 0) { > device_printf(dev, > "The EEPROM Checksum Is Not Valid\n"); > return (EIO); > } > } > > This is already checked into my code base at Intel, I've just been too > busy to do anything with it, be my guest if you wish to check it in after > testing... > > Cheers, > > Jack > LOL, opps, I just realized, this code reflects the new shared code that I am in the process of releasing, in order for this to work in 6.2 change 'e1000_validate_nvm_checksum' to 'em_validate_eeprom_checksum' and all should be clear :) Jack