From owner-freebsd-net@FreeBSD.ORG Wed May 26 20:35:31 2010 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id D86DB1065677 for ; Wed, 26 May 2010 20:35:31 +0000 (UTC) (envelope-from jfvogel@gmail.com) Received: from mail-wy0-f182.google.com (mail-wy0-f182.google.com [74.125.82.182]) by mx1.freebsd.org (Postfix) with ESMTP id 6A4C78FC13 for ; Wed, 26 May 2010 20:35:31 +0000 (UTC) Received: by wyj26 with SMTP id 26so1802599wyj.13 for ; Wed, 26 May 2010 13:35:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:received:in-reply-to :references:date:message-id:subject:from:to:cc:content-type; bh=cE2YLraoQAsZ3f02Vy3jelV5DFMZUDMgP98WHUns2vU=; b=Yf+M3r2+1yHUeImzm3RFpQ6Cv7e3v5Uw4kqrYdpIXf8WHXnZ5OiDSp7Z2W5xp26fqy 34/MbBMgp2bnylLDhSjIaWyPoiHq7Lwt4T7O3bqnSDl4DaLqsyndRXRmlAA4UHJGaqS/ 1XEbKGkPJmSUjU3yag0sw3HLsFywV7lNLNpWQ= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; b=U5c7jEYTlat+0tK0QPj0pZux8zerip2iDaR1uAZRQ3vq/34Jx1iX3Y0JccKeiNQ+0U 4ErXNFMcUvWgetAKi2+i+li7/2NRi9r7crE67ghLMqSSJ0HeNVXqY1nTI+7G3Natxe3m BeNzufxgCWpqSAoK1ETGHf8ykHu8oIAHdYm90= MIME-Version: 1.0 Received: by 10.216.181.73 with SMTP id k51mr78152wem.113.1274906130285; Wed, 26 May 2010 13:35:30 -0700 (PDT) Received: by 10.216.29.129 with HTTP; Wed, 26 May 2010 13:35:29 -0700 (PDT) In-Reply-To: <20100526200044.GA80693@icir.org> References: <20100514180151.GA8175@icir.org> <20100519042100.GB6390@icir.org> <20100519162032.GE6390@icir.org> <20100525190310.GB32901@icir.org> <20100526200044.GA80693@icir.org> Date: Wed, 26 May 2010 13:35:29 -0700 Message-ID: From: Jack Vogel To: Robin Sommer Content-Type: text/plain; charset=ISO-8859-1 X-Content-Filtered-By: Mailman/MimeDel 2.1.5 Cc: freebsd-net@freebsd.org Subject: Re: Crashes with ixgbe on FreeBSD 8 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 26 May 2010 20:35:32 -0000 Well, its one way to do it, and no, its not a problem, what I was planning on doing was copying the macro into my header file. Jack On Wed, May 26, 2010 at 1:00 PM, Robin Sommer wrote: > > On Tue, May 25, 2010 at 12:03 -0700, I wrote: > > > /usr/src/sys/dev/ixgbe/ixgbe.c:833: warning: implicit declaration of > function 'drbr_needs_enqueue' > > So, I've now simply copied that function over and, indeed, that not > only compiles but gives me a working 2.2.0 driver, enabling me to > capture traffic in a stable fashion as far as I can tell so far ... > > My question: is simply pasting this function into RELEASE a > reasonable fix, or am I missing out on further changes and am thus > getting myself into trouble in some form? > > Robin > > -- > Robin Sommer * Phone +1 (510) 666-2886 * robin@icir.org > ICSI/LBNL * Fax +1 (510) 666-2956 * www.icir.org >