From owner-svn-src-all@freebsd.org Thu Nov 24 15:21:08 2016 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id D392CC5372E; Thu, 24 Nov 2016 15:21:08 +0000 (UTC) (envelope-from danfe@freebsd.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "freefall.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id C73F7847; Thu, 24 Nov 2016 15:21:08 +0000 (UTC) (envelope-from danfe@freebsd.org) Received: by freefall.freebsd.org (Postfix, from userid 1033) id BCC701982; Thu, 24 Nov 2016 15:21:08 +0000 (UTC) Date: Thu, 24 Nov 2016 15:21:08 +0000 From: Alexey Dokuchaev To: Kubilay Kocak Cc: Dag-Erling Sm??rgrav , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r309109 - head/lib/libutil Message-ID: <20161124152108.GA20603@FreeBSD.org> References: <201611241450.uAOEoLA5079215@repo.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.7.1 (2016-10-04) X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 24 Nov 2016 15:21:08 -0000 On Fri, Nov 25, 2016 at 01:56:36AM +1100, Kubilay Kocak wrote: > On 25/11/2016 1:50 AM, Dag-Erling Sm??rgrav wrote: > > +/* + * Reliably open and lock a file. + * + * DO NOT, UNDER PAIN OF > > DEATH, modify this code without first reading the + * revision > > history and discussing your changes with . + * Don't > > be fooled by the code's apparent simplicity; there would be no + * > > need for this function if it was as easy to get right as you think. + > > */ (Garbled quoting; please fix you MUA.) > This comes as close to obvious territoriality in FreeBSD as I've seen to > date and it's especially disappointing to see coming from someone many > look up to and consider a senior project developer. Apparently des@ was/is unhappy about unthought changes made to this code; what exactly makes his wish territorialiting and disappointing? > While we all may understand the frustration associated with people > changing code they don't understand, I believe we need less fear > associated with contributing to FreeBSD and that this is a big step in > the wrong direction. Dag-Erling's comment is perfectly fine; loud and clear. Those who want to contribute should read the prior history and ping des@; I don't see anything wrong with this (and given how reluctantly people are eager to do "svn blame" these days, I don't think this is uncalled). ./danfe