Date: Sun, 19 Mar 2017 14:19:23 +0000 From: bugzilla-noreply@freebsd.org To: freebsd-fs@FreeBSD.org Subject: [Bug 217879] [ufs] couple of cppcheck findings Message-ID: <bug-217879-3630-6UEQDAiEbi@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-217879-3630@https.bugs.freebsd.org/bugzilla/> References: <bug-217879-3630@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D217879 Konstantin Belousov <kib@FreeBSD.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |Not A Bug Status|New |Closed --- Comment #1 from Konstantin Belousov <kib@FreeBSD.org> --- The report is false, and patch is wrong. The code tries to find a first element of the specific type (D_JSEGDEP in c= ase of jwork_insert, D_ALLOCDIRECT for setup_newdir). This is done by the LIST_FOREACH() loop. If no element was found, i.e. the condition wk =3D=3D= NULL after the loop, then something other is done. The patch breaks the logic. --=20 You are receiving this mail because: You are the assignee for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-217879-3630-6UEQDAiEbi>