Date: Tue, 25 Jun 2019 11:13:12 +0200 From: Piotr Kubaj <pkubaj@anongoth.pl> To: Kubilay Kocak <koobs@freebsd.org> Cc: "Tobias C. Berner" <tcberner@gmail.com>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r505045 - head/sysutils/plasma5-ksysguard Message-ID: <20190625091312.GB63640@KGPE-D16> In-Reply-To: <5878f408-2030-7f57-ec1e-5f45e814433f@FreeBSD.org> References: <201906241810.x5OIAu1h080487@repo.freebsd.org> <CAOshKtcPHHa4%2Bv2kL_aNKXzoXs1VkGw0nEAx3PkaArPJ6kCGzw@mail.gmail.com> <20190624194627.GB49520@ThinkPad-X200.g.anongoth.pl> <CAOshKtegUmUYfdnDNmt9wuk1cSC_z_qpz8td597zC4y3Dup_-w@mail.gmail.com> <20190624202703.GA68048@ThinkPad-X200.g.anongoth.pl> <8eab69dc-52bb-a187-6a30-565ae58f4512@FreeBSD.org> <20190625082911.GA63640@KGPE-D16> <5878f408-2030-7f57-ec1e-5f45e814433f@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--H+4ONPRPur6+Ovig Content-Type: text/plain; charset=utf-8; format=flowed Content-Disposition: inline Content-Transfer-Encoding: quoted-printable OK then, I get the meaning of this flag now. Still, it would be good if you could post some FAQ on bugzilla so that othe= rs know too :) On 19-06-25 18:45:33, Kubilay Kocak wrote: >On 25/06/2019 6:29 pm, Piotr Kubaj wrote: >> To be honest, I fail to see the meaning of this flag. >> >> If it's not about approval, then what does this flag actually mean? Only >> that "I acknowledge that there's a problem"? > >It means feedback is required. Feedback can take many forms. Not all >bugs are patch submissions requiring (only) approval from a maintainer. > >Take for example, a bug report without a patch. maintainer-feedback? is >set when issue is created. The maintainer comes back with 'i can >reproduce the problem' and sets maintainer-feedback + (feedback >provided). Triage sets need-patch keyword requesting a patch to fix the >issue and sets maintainer-feedback? again, feedback this time being in >the form of a patch. > >> Then maybe work-in-progress? As in, the maintainer is working on the fix. > >This doesn't cover feedback of forms that don't involve work/patches, >the vast majority, and this is already covered by needs-patch keyword in >any case. > >Again, if there's any way to improve the maintainer-feedback flag name >to not mean 'approval' (as thats not what its for), I'd been keen to >hear ideas. > > >> On 19-06-25 11:59:32, Kubilay Kocak wrote: >>> On 25/06/2019 6:27 am, Piotr Kubaj wrote: >>>> OK, for me maintainer-feedback entry means that the patch is accepted. >>>> >>>> When I wasn't a committer, I used to set maintainer-feedback to indica= te >>>> that I accept the patch. When I send PR's nowadays, some maintainers >>>> also do that. >>>> >>>> On 19-06-24 21:54:56, Tobias C. Berner wrote: >>>>> I set maintainer feedback, because I, as the maintainer gave you the >>>>> feedback, that "I think this is wrong" :) >>>>> If I liked that patch, I would have set the patch-approved flag on it. >>>>> >>>>> >>>>> All that said, thanks for "fixing" it, but I still would prefer a real >>>>> fix, >>>>> that we can upstream rather than that. >>>>> >>>>> >>>>> mfg Tobias >>>>> >>>>> >>>>> On Mon, 24 Jun 2019 at 21:46, Piotr Kubaj <pkubaj@anongoth.pl> wrote: >>>>> >>>>>> Oh, I didn't use "implicit". Doesn't maintainer-feedback + mean that >>>>>> it's >>>>>> accepted? >>>>>> >>>>>> On 19-06-24 21:34:09, Tobias C. Berner wrote: >>>>>> >Moin moin >>>>>> > >>>>>> >Sorry, but I explicitely did not approve this :) so using implicit >>>>>> on it, >>>>>> >is a bit of a crappy move. >>>>>> > >>>>>> >mfg Tobias >>>>>> > >>>>>> >On Mon, 24 Jun 2019 at 20:11, Piotr Kubaj <pkubaj@freebsd.org> wrot= e: >>>>>> > >>>>>> >> Author: pkubaj >>>>>> >> Date: Mon Jun 24 18:10:55 2019 >>>>>> >> New Revision: 505045 >>>>>> >> URL: https://svnweb.freebsd.org/changeset/ports/505045 >>>>>> >> >>>>>> >> Log: >>>>>> >>=C2=A0=C2=A0 sysutils/plasma5-ksysguard: fix build with GCC-based >>>>>> architectures >>>>>> >> >>>>>> >>=C2=A0=C2=A0 Link with libinotify explicitly to fix linking on GCC >>>>>> architectures. >>>>>> >> >>>>>> >>=C2=A0=C2=A0 PR:=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0 238702 >>>>>> >>=C2=A0=C2=A0 Approved by:=C2=A0 tcberner (maintainer, mentor) >>>>>> >> >>>>>> >> Modified: >>>>>> >>=C2=A0=C2=A0 head/sysutils/plasma5-ksysguard/Makefile >>>>>> >> >>>>>> >> Modified: head/sysutils/plasma5-ksysguard/Makefile >>>>>> >> >>>>>> >> >>>>>> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D >>>>>> >>>>>> >>>>>> >> --- head/sysutils/plasma5-ksysguard/Makefile=C2=A0=C2=A0=C2=A0 Mo= n Jun 24 >>>>>> 18:07:12 2019 >>>>>> >>=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (r505044) >>>>>> >> +++ head/sysutils/plasma5-ksysguard/Makefile=C2=A0=C2=A0=C2=A0 Mo= n Jun 24 >>>>>> 18:10:55 2019 >>>>>> >>=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (r505045) >>>>>> >> @@ -23,5 +23,6 @@ OPTIONS_SUB=3D=C2=A0 yes >>>>>> >> >>>>>> >>=C2=A0 INOTIFY_DESC=3D=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0 Filesystem alteration notifications using >>>>>> inotify >>>>>> >>=C2=A0 INOTIFY_LIB_DEPENDS=3D=C2=A0=C2=A0 libinotify.so:devel/libi= notify >>>>>> >> +INOTIFY_LDFLAGS=3D=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 -linotify >>>>>> >> >>>>>> >>=C2=A0 .include <bsd.port.mk> >>> >>> >>> What could we (bugmeister) name the flag so that it was clear that >>> >>> a) The flag is about needing feedback >>> b) The flag has nothing to do with / does not mean approval? >>> >>> > > > > >--=20 >This message has been scanned for viruses and >dangerous content by MailScanner, and is >believed to be clean. > --H+4ONPRPur6+Ovig Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEycyIeNkkgohzsoorelmbhSCDnJ0FAl0R5agACgkQelmbhSCD nJ1qsw//SplkAqgzoPYAbl1sqe7cDHZHaF3/ByRGPibhrHmYkulL8xI1qb7QqgCf tTOEqJIGPMc9zuXS7UaWkWvpDltsnc34/iE/meWhR/LC2ey9S9nTk5a+LLP33IMq Y+4vMosPKCNXRlRMTTG/UHGUAPfw41h2hjfIf6D0g3xQSnQrsouyW8/uDM6Za9en GEd81iIQktlXiNdjo0zRlaPX8uEzaxiaAGfO8zKbZCv7ZcDBdxHKuN4+dhLCEQvf QjBz5r1IIfNOEIixDq7JH0e/JbQbij/CPlKZEVFXnJ0SR/S1Vc0o3+Jga4tYBKas wOgedNpvD3GXnZxxzBt5OnBNO2WvVzhWUIh9DD1GG/mvuQ9Sb9OyhGpA3XUPBpJw 9QuLoTOJy0+jQsbXPcpOrpT955tXCeQL6YC6qy6Q80OakS4vrb8WYbR3P6wwsXpC asduBEo+i1cC7C1OlANg6Z/dI3ssYV0t9esCOVJmdbok9L6jW5p0BRLs3VNFtM0W PLveHZkAyi/+rbqJfOwCSrBMzXUijD/4dxzbG61tLe20Okr3kgMci+9RBQnOtA0l XPsBORQ3e3hIM9LB+zOfuYEbrAA/LjDmkSl8LDbpNP2zJifNwDxGVauSH7EqsChp 2SeOhT0uzzvoZgJn0RCDtFtFWjzbrR4VUnWGFE0/DBqgIyyKXeQ= =FvL8 -----END PGP SIGNATURE----- --H+4ONPRPur6+Ovig--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20190625091312.GB63640>