From owner-svn-src-all@FreeBSD.ORG Sun Oct 28 09:04:23 2012 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 0312924C; Sun, 28 Oct 2012 09:04:23 +0000 (UTC) (envelope-from pluknet@gmail.com) Received: from mail-ie0-f182.google.com (mail-ie0-f182.google.com [209.85.223.182]) by mx1.freebsd.org (Postfix) with ESMTP id 947C58FC08; Sun, 28 Oct 2012 09:04:22 +0000 (UTC) Received: by mail-ie0-f182.google.com with SMTP id k10so7062890iea.13 for ; Sun, 28 Oct 2012 02:04:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type; bh=gfth/WKpc3/NrsKqSKg3tFfuewj5ZkGpwSYEypB+vSo=; b=KaeRUeDZyiwkV0GvdtjweJdB3/Kln8uuoFdbr9fgqeqiv/BqQc8CWb95xDjBCvAfEM v/Qr/G9q7+WKd7acdGLhcEMYa7bZBFuOKzmP/UdgrxI5LNW6GdAxwJLyox9Zm7ebq7Wr PqkhgVgbEWgalW8h/lSw455tkcZvvsQ7ANgHo6wT7MG+TAnsenbj1MLqxXFo6wpvwEBG sXnRg0BJp+3Gpgbkt6nENf9qaI5JgZVWQjh43pEWsynfBX0eeu6jABWLLXaLOQgc27O2 UGjimh7XY0a7OgFFKqfa14dF5B84CsD+zlllIACl6rpPT3BTfTfsFd82ng3BFrWeLwkz dxqQ== MIME-Version: 1.0 Received: by 10.50.242.74 with SMTP id wo10mr6582771igc.51.1351415062005; Sun, 28 Oct 2012 02:04:22 -0700 (PDT) Sender: pluknet@gmail.com Received: by 10.64.47.228 with HTTP; Sun, 28 Oct 2012 02:04:21 -0700 (PDT) In-Reply-To: <201210272342.q9RNgffr083366@svn.freebsd.org> References: <201210272342.q9RNgffr083366@svn.freebsd.org> Date: Sun, 28 Oct 2012 12:04:21 +0300 X-Google-Sender-Auth: d_cn91ksQLCIyd6LLt3Op0c_t9E Message-ID: Subject: Re: svn commit: r242202 - head/sys/kern From: Sergey Kandaurov To: Davide Italiano Content-Type: text/plain; charset=ISO-8859-1 Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 28 Oct 2012 09:04:23 -0000 On 28 October 2012 03:42, Davide Italiano wrote: > Author: davide > Date: Sat Oct 27 23:42:41 2012 > New Revision: 242202 > URL: http://svn.freebsd.org/changeset/base/242202 > > Log: > The fields of struct timespec32 should be int32_t and not uint32_t. > Make this change. > > Reviewed by: bde, davidxu > Tested by: pho > MFC after: 1 week > > Modified: > head/sys/kern/kern_umtx.c > > Modified: head/sys/kern/kern_umtx.c > ============================================================================== > --- head/sys/kern/kern_umtx.c Sat Oct 27 23:36:41 2012 (r242201) > +++ head/sys/kern/kern_umtx.c Sat Oct 27 23:42:41 2012 (r242202) > @@ -3291,8 +3291,8 @@ freebsd32_umtx_unlock(struct thread *td, > } > > struct timespec32 { > - uint32_t tv_sec; > - uint32_t tv_nsec; > + int32_t tv_sec; > + int32_t tv_nsec; > }; > > struct umtx_time32 { Thanks. It could be fine to take this from compat/freebsd32, OTOH it hardly makes sense for me. IMHO duplicating a single struct definition is sometimes lesser evil than inclusion pile of unused stuff from yet another header(s). -- wbr, pluknet