Date: Thu, 20 Feb 2025 15:59:12 +0100 From: Michal Meloun <meloun.michal@gmail.com> To: "Bjoern A. Zeeb" <bz@freebsd.org>, Gleb Smirnoff <glebius@freebsd.org> Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 61ce42253180 - main - wlanstats: move from tools to usr.sbin Message-ID: <5678bc5e-eb1b-4ac5-8b34-c7a7bfac5816@gmail.com> In-Reply-To: <q8r8o1r5-oo7o-q9r6-o2oo-nr0s44o796pn@serrofq.bet> References: <202502190257.51J2vRTI049767@gitrepo.freebsd.org> <Z7YWRK6Plp2gsbhd@cell.glebi.us> <q8r8o1r5-oo7o-q9r6-o2oo-nr0s44o796pn@serrofq.bet>
next in thread | previous in thread | raw e-mail | index | archive | help
On 19.02.2025 18:40, Bjoern A. Zeeb wrote: > On Wed, 19 Feb 2025, Gleb Smirnoff wrote: > >> On Wed, Feb 19, 2025 at 02:57:27AM +0000, Bjoern A. Zeeb wrote: >> B> commit 61ce422531805307d413bf04c9ad1aabd7f3a879 >> B> Author: Bjoern A. Zeeb <bz@FreeBSD.org> >> B> AuthorDate: 2025-02-19 02:50:11 +0000 >> B> Commit: Bjoern A. Zeeb <bz@FreeBSD.org> >> B> CommitDate: 2025-02-19 02:56:59 +0000 >> B> >> B> wlanstats: move from tools to usr.sbin >> B> >> B> wlanstats is an incredible tool to get a quick overview of state >> B> of affairs of wireless by looking at the counters. >> B> And it makes it simple. >> B> >> B> Having landed the LinuxKPI HW_CRYPTO bits I was asked by users >> B> what to check and I realised the answer is in wlanstats. >> B> >> B> It is annoying even as a developer to manually build it for each >> B> installation but given it's also useful to users and support >> B> make it available with the general installation. >> B> Probably very long overdue. >> B> >> B> Adjust the Makefile and make build again on main. >> B> Hook it up to the build conditional on MK_WIRELESS. >> B> >> B> Discussed with: adrian >> B> Sponsored by: The FreeBSD Foundation >> B> TODO: man page >> >> Please let's not create a precedent of a new utility without >> a manual page. Better one with grammar mistakes and terse >> than nothing. > > Better one that #manpage has reviewed than anything else. > >> This takes less than 15 minutes. Please, fill >> this gap. > > I will; otherwise I wouldn't have mentioned it and just moved on? > > > /bz > Unfortunately, the code contains invalid behaviour. In many places it uses the following construct: struct wlanstatfoo_p *wf = (struct wlanstatfoo_p *) wf0; where wf0 is struct wlanstatfoo type. These types are not compatible and have different alignment requirements, so these are cannot be compiled at least on arm32. Moreover naming looks wrong, because wlanstatfoo_p is not pointer to struct wlanstatfoo, but to different structure. Please revert it and push fixed version. Michal
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?5678bc5e-eb1b-4ac5-8b34-c7a7bfac5816>