From owner-svn-src-head@freebsd.org Tue Mar 7 17:24:40 2017 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 5C825D01631; Tue, 7 Mar 2017 17:24:40 +0000 (UTC) (envelope-from cse.cem@gmail.com) Received: from mail-wr0-f172.google.com (mail-wr0-f172.google.com [209.85.128.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id E78141FB1; Tue, 7 Mar 2017 17:24:39 +0000 (UTC) (envelope-from cse.cem@gmail.com) Received: by mail-wr0-f172.google.com with SMTP id g10so6345358wrg.2; Tue, 07 Mar 2017 09:24:39 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:reply-to:in-reply-to:references :from:date:message-id:subject:to:cc; bh=z9HOtJFXM/zv8oaYUUzshmeQFq0DQM/143nE4DZR8ko=; b=GafSDW+m1tulydVV4Pm0tFi1NNnGPRatzoHY325SZ9j3lWIEJGs8G3N6y7ZVrIKqbI 7QIorSzOTX+lwbGWMC3vaKEQb6Pe18LslVg1F7KL43yplnPKEV8KfK0pudiz4dgZm6NI MTJ6z3pCbfLX0CWTn/LFiX5NKzc0K7HeGZVzLWw9PjfTCtScgPstSir620ptdqnYAg1f /J7DXyONkXj2TTLb1Y5JC/mkV+TpdnvjaSdCsqkbaJldtOdl1O+d/bTAXEgghUTNR4Q/ IMpCJoaTImXPiL/dwNey2Pgebpw4QhPqaEPkRvobf4SxpqYYppnZ51Y7/VJttwy8/icS vWGQ== X-Gm-Message-State: AMke39lu+JPYqKiFjREG0HINQTN1Y0Ks4tLci3qfA378NHDiWPEQw1pipwGm+ZOaHY/jDg== X-Received: by 10.223.136.33 with SMTP id d30mr1247157wrd.117.1488905997557; Tue, 07 Mar 2017 08:59:57 -0800 (PST) Received: from mail-wm0-f42.google.com (mail-wm0-f42.google.com. [74.125.82.42]) by smtp.gmail.com with ESMTPSA id e16sm715892wra.36.2017.03.07.08.59.57 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 07 Mar 2017 08:59:57 -0800 (PST) Received: by mail-wm0-f42.google.com with SMTP id v186so94935816wmd.0; Tue, 07 Mar 2017 08:59:57 -0800 (PST) X-Received: by 10.28.111.136 with SMTP id c8mr1751047wmi.128.1488905996993; Tue, 07 Mar 2017 08:59:56 -0800 (PST) MIME-Version: 1.0 Reply-To: cem@freebsd.org Received: by 10.80.169.4 with HTTP; Tue, 7 Mar 2017 08:59:56 -0800 (PST) In-Reply-To: References: <201703070020.v270K2vA039655@repo.freebsd.org> From: Conrad Meyer Date: Tue, 7 Mar 2017 08:59:56 -0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: svn commit: r314813 - head/sys/kern To: Hiren Panchasara Cc: src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset=UTF-8 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 07 Mar 2017 17:24:40 -0000 Sorry, I had not seen r314838 yet. Please disregard. Thanks, Conrad On Tue, Mar 7, 2017 at 8:58 AM, Conrad Meyer wrote: > Hi Hiren, > > On Mon, Mar 6, 2017 at 4:20 PM, Hiren Panchasara wrote: >> Author: hiren >> Date: Tue Mar 7 00:20:01 2017 >> New Revision: 314813 >> URL: https://svnweb.freebsd.org/changeset/base/314813 >> >> ... >> @@ -1043,6 +1043,11 @@ sbcut_internal(struct sockbuf *sb, int l >> { >> struct mbuf *m, *next, *mfree; >> >> + KASSERT(len > 0, ("%s: len is %d but it is supposed to be +ve", >> + __func__, len)); > > Can you change the spelling from +ve to positive? I guess that might > mean wrapping the line, but I find the full word much more clear. > (Also, I guess the assert is >= 0 now? So that should read > "non-negative" rather than "positive." :-) ) > > >> + KASSERT(len <= sb->sb_ccc, ("%s: len: %d is > ccc: %u", >> + __func__, len, sb->sb_ccc)); >> + >> next = (m = sb->sb_mb) ? m->m_nextpkt : 0; >> mfree = NULL; > > Best, > Conrad