From owner-freebsd-fs@freebsd.org Tue Jul 19 10:06:34 2016 Return-Path: Delivered-To: freebsd-fs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id ACF80B9E8D6 for ; Tue, 19 Jul 2016 10:06:34 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 83DD613CA for ; Tue, 19 Jul 2016 10:06:34 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id u6JA6YM5039426 for ; Tue, 19 Jul 2016 10:06:34 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-fs@FreeBSD.org Subject: [Bug 93942] [vfs] [patch] panic: ufs_dirbad: bad dir (patch from DragonFly) Date: Tue, 19 Jul 2016 10:06:34 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 6.1-PRERELEASE X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: kib@FreeBSD.org X-Bugzilla-Status: In Progress X-Bugzilla-Resolution: X-Bugzilla-Priority: Normal X-Bugzilla-Assigned-To: freebsd-fs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: cc Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Jul 2016 10:06:34 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D93942 Konstantin Belousov changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kib@FreeBSD.org --- Comment #12 from Konstantin Belousov --- (In reply to rdarbha from comment #11) Do you understand that your question contains the intrinsic contradiction ? Anyway, I looked at the Matt' patches. The vfs_cluster changes seems to be irrelevant, we start io (and perform SU-related rollbacks) in ffs_geom_strategy() which is executed after the cluster is fully constructed and validated. Similarly, we assert that there is no dandling dependencies when B_NOCACHE buffer is thrown away in brelse(). So I think that these bi= ts are not (directly) relevant to us. The interesting stuff is vnode vm_object size handling for directories. Th= is is the right thing to do, but I doubt that we would have issues with the present order as far as vnode is not unlocked between buffer allocation and pager resizing. Still it is better to do it right, patch is attached. If you have dirbad panics, I would first check your hardware and verified integrity of other files on the same volume. If you have canonical copy of= the data, say system distribution disk which was used to install, compare the checksums of regular files. --=20 You are receiving this mail because: You are the assignee for the bug.=