From owner-svn-src-projects@FreeBSD.ORG Fri Jan 23 00:18:13 2015 Return-Path: Delivered-To: svn-src-projects@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 34A2D3E4; Fri, 23 Jan 2015 00:18:13 +0000 (UTC) Received: from mail-pa0-x22f.google.com (mail-pa0-x22f.google.com [IPv6:2607:f8b0:400e:c03::22f]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 0599CBBF; Fri, 23 Jan 2015 00:18:13 +0000 (UTC) Received: by mail-pa0-f47.google.com with SMTP id lj1so5005788pab.6; Thu, 22 Jan 2015 16:18:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=content-type:mime-version:subject:from:in-reply-to:date:cc :message-id:references:to; bh=MDfvR02qLF7LvfNZo9zxI0vIpUGtt2BxP0mkf+ny+9Q=; b=pSmwmrx5aJTEy50nSt7fxTAqEmMqgugvTTuACFqfahot0CGgw8nmVrBPxCAbDAUAIX Z3JBdQliI408Okox3hxzTiDpoTl9hcQYMzpAgOlIQqgNR34tjYU0xJIYPyz5t+1tZVzZ p5SJUb2AIB/oG6No/VSeXo45cghZZG4HaZ5Npv73dpxh21+0Uj8sHEKAqausXQHPxiV9 +rfMSx8EOoF37nEy0XCJl0seRmcdICLcsFhVWXT75plsm009ob8geb4e+RJ+MGD3SSYR KilJlUE1GQSl3w5oZIhM3zM9I3nqJUevfHvevvBjnd1/UkqeGapQ8u3gBEQdNRJ/M3tU Ck3A== X-Received: by 10.68.141.204 with SMTP id rq12mr6537219pbb.7.1421972292201; Thu, 22 Jan 2015 16:18:12 -0800 (PST) Received: from [192.168.242.58] (c-67-182-131-225.hsd1.wa.comcast.net. [67.182.131.225]) by mx.google.com with ESMTPSA id nj2sm10121162pbc.16.2015.01.22.16.18.11 (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Thu, 22 Jan 2015 16:18:11 -0800 (PST) Content-Type: multipart/signed; boundary="Apple-Mail=_BF38F50E-EF39-4C35-A731-1A4E35746C86"; protocol="application/pgp-signature"; micalg=pgp-sha512 Mime-Version: 1.0 (Mac OS X Mail 7.3 \(1878.6\)) Subject: Re: svn commit: r277543 - projects/ifnet/sys/net From: Garrett Cooper In-Reply-To: <201501230002.t0N02R5W099367@svn.freebsd.org> Date: Thu, 22 Jan 2015 16:18:08 -0800 Message-Id: <21EFD3A7-91CA-4FF9-BD84-C6AD847A11ED@gmail.com> References: <201501230002.t0N02R5W099367@svn.freebsd.org> To: Gleb Smirnoff X-Mailer: Apple Mail (2.1878.6) Cc: svn-src-projects@freebsd.org, src-committers@freebsd.org X-BeenThere: svn-src-projects@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: "SVN commit messages for the src " projects" tree" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 23 Jan 2015 00:18:13 -0000 --Apple-Mail=_BF38F50E-EF39-4C35-A731-1A4E35746C86 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=windows-1252 On Jan 22, 2015, at 16:02, Gleb Smirnoff wrote: > Author: glebius > Date: Fri Jan 23 00:02:26 2015 > New Revision: 277543 > URL: https://svnweb.freebsd.org/changeset/base/277543 >=20 > Log: > Return EOPNOTSUPP in case of not supported option. >=20 > Modified: > projects/ifnet/sys/net/if_ethersubr.c >=20 > Modified: projects/ifnet/sys/net/if_ethersubr.c > = =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D > --- projects/ifnet/sys/net/if_ethersubr.c Thu Jan 22 23:59:35 2015 = (r277542) > +++ projects/ifnet/sys/net/if_ethersubr.c Fri Jan 23 00:02:26 2015 = (r277543) > @@ -985,7 +985,7 @@ ether_ioctl(struct ifnet *ifp, u_long co > } > break; > default: > - error =3D EINVAL; /* XXX netbsd = has ENOTTY??? */ > + error =3D EOPNOTSUPP; > break; > } > return (error); Uh, didn=92t you just break the ioctl(2) ERRORS guarantee? [EBADF] The fd argument is not a valid descriptor. [ENOTTY] The fd argument is not associated with a = character special device. [ENOTTY] The specified request does not apply to the kind = of object that the descriptor fd references. [EINVAL] The request or argp argument is not valid. [EFAULT] The argp argument points outside the process's allocated address space. --Apple-Mail=_BF38F50E-EF39-4C35-A731-1A4E35746C86 Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iQEcBAEBCgAGBQJUwZNAAAoJEMZr5QU6S73eWZ0H/0Zr7K9rAT5uqt2+rE062TPs 98cFQ3hmycz5R+83h/gE+zoyq6nVhtCAh+QVpn9tpHRhl8USpg7DErhFxuekbT6E vkNEsSRdgf17EIyMPBFHhotV3NfmYhVeuuc0hTlsWMyVoxgQp6XA6V8aR/W2dLoN yqZrnxf6olWvr5zYtyQkpt81lxNA/9JawcfqvPntbR7LncsSw1j8VnLM1nuDW+ou 0xTE95gtZ3Tb3YrXc37I3HIFbAbM0o6fNU2s3Vs5xikRhcSM/2P5WSB0BykByfIv 3q4hbK81MFjKIXEJ+gZ8DXqrQkG9ShvSKqkChhD1yiHMfhzLur1sZvJ3Wzw64kU= =dC2W -----END PGP SIGNATURE----- --Apple-Mail=_BF38F50E-EF39-4C35-A731-1A4E35746C86--