From owner-cvs-all@FreeBSD.ORG Fri Sep 17 20:21:57 2004 Return-Path: <owner-cvs-all@FreeBSD.ORG> Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 0AE5416A4CF; Fri, 17 Sep 2004 20:21:57 +0000 (GMT) Received: from arginine.spc.org (arginine.spc.org [195.206.69.236]) by mx1.FreeBSD.org (Postfix) with ESMTP id AFBA943D46; Fri, 17 Sep 2004 20:21:56 +0000 (GMT) (envelope-from bms@spc.org) Received: from localhost (localhost [127.0.0.1]) by arginine.spc.org (Postfix) with ESMTP id E4C65653F8; Fri, 17 Sep 2004 21:21:55 +0100 (BST) Received: from arginine.spc.org ([127.0.0.1]) by localhost (arginine.spc.org [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 63821-01-2; Fri, 17 Sep 2004 21:21:55 +0100 (BST) Received: from empiric.dek.spc.org (adsl-64-171-184-46.dsl.snfc21.pacbell.net [64.171.184.46]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by arginine.spc.org (Postfix) with ESMTP id 3D246651F7; Fri, 17 Sep 2004 21:21:55 +0100 (BST) Received: by empiric.dek.spc.org (Postfix, from userid 1001) id 1FA016425; Fri, 17 Sep 2004 13:21:53 -0700 (PDT) Date: Fri, 17 Sep 2004 13:21:53 -0700 From: Bruce M Simpson <bms@spc.org> To: Gleb Smirnoff <glebius@FreeBSD.org> Message-ID: <20040917202153.GG6019@empiric.icir.org> Mail-Followup-To: Gleb Smirnoff <glebius@FreeBSD.org>, src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org References: <200409171946.i8HJkeIt094774@repoman.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200409171946.i8HJkeIt094774@repoman.freebsd.org> cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/pci if_xl.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org> List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>, <mailto:cvs-all-request@freebsd.org?subject=unsubscribe> List-Archive: <http://lists.freebsd.org/pipermail/cvs-all> List-Post: <mailto:cvs-all@freebsd.org> List-Help: <mailto:cvs-all-request@freebsd.org?subject=help> List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>, <mailto:cvs-all-request@freebsd.org?subject=subscribe> X-List-Received-Date: Fri, 17 Sep 2004 20:21:57 -0000 On Fri, Sep 17, 2004 at 07:46:40PM +0000, Gleb Smirnoff wrote: > MFC 1.180: > Do not call xl_init_locked() unconditionally when we are bringed UP. Call > it only if we weren't UP before. In some cases xl_init causes long media > re-negotiation, and ppp(8) fails to open PPPoE connection because it sets > IFF_UP every time before opening PPPoE connection. Hey, nice fix. BMS