From owner-freebsd-bugs@FreeBSD.ORG Wed Mar 31 07:20:08 2010 Return-Path: Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 8008E1065675 for ; Wed, 31 Mar 2010 07:20:08 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 42E298FC17 for ; Wed, 31 Mar 2010 07:20:08 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id o2V7K8th087731 for ; Wed, 31 Mar 2010 07:20:08 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.4/8.14.4/Submit) id o2V7K845087730; Wed, 31 Mar 2010 07:20:08 GMT (envelope-from gnats) Resent-Date: Wed, 31 Mar 2010 07:20:08 GMT Resent-Message-Id: <201003310720.o2V7K845087730@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Garrett Cooper Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 8E97F1065763 for ; Wed, 31 Mar 2010 07:10:49 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21]) by mx1.freebsd.org (Postfix) with ESMTP id 780158FC08 for ; Wed, 31 Mar 2010 07:10:49 +0000 (UTC) Received: from www.freebsd.org (localhost [127.0.0.1]) by www.freebsd.org (8.14.3/8.14.3) with ESMTP id o2V7AnGj036983 for ; Wed, 31 Mar 2010 07:10:49 GMT (envelope-from nobody@www.freebsd.org) Received: (from nobody@localhost) by www.freebsd.org (8.14.3/8.14.3/Submit) id o2V7AnNt036982; Wed, 31 Mar 2010 07:10:49 GMT (envelope-from nobody) Message-Id: <201003310710.o2V7AnNt036982@www.freebsd.org> Date: Wed, 31 Mar 2010 07:10:49 GMT From: Garrett Cooper To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-3.1 Cc: Subject: bin/145230: mtree(8) -P is broken because l* functions aren't being used X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 31 Mar 2010 07:20:08 -0000 >Number: 145230 >Category: bin >Synopsis: mtree(8) -P is broken because l* functions aren't being used >Confidential: no >Severity: serious >Priority: medium >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Wed Mar 31 07:20:07 UTC 2010 >Closed-Date: >Last-Modified: >Originator: Garrett Cooper >Release: 9-CURRENT >Organization: Cisco Systems, Inc. >Environment: FreeBSD bayonetta.local 9.0-CURRENT FreeBSD 9.0-CURRENT #5 r205310: Sat Mar 20 01:32:51 PDT 2010 gcooper@bayonetta.local:/usr/obj/usr/src/sys/BAYONETTA amd64 >Description: As discovered when reviewing mtree(8) as part of bin/144411, there are a number of items with -P that doesn't work... all chown, chmod, and stat calls for instance are the non-l variety, which means that unfortunately the file information for symlinks isn't being properly recorded. Furthermore, in verify.c where lchown is used: if (!(p->flags & (F_UID | F_UNAME))) (void)printf(" (%s not created: user not specified)", type); else if (!(p->flags & (F_GID | F_GNAME))) (void)printf(" (%s not created: group not specified)", type); else if (p->type == F_LINK) { if (symlink(p->slink, path)) (void)printf(" (symlink not created: %s)\n", strerror(errno)); else (void)printf(" (created)\n"); if (lchown(path, p->st_uid, p->st_gid) == -1) { the symlink data isn't being properly recorded; it's resolving the file instead, which may store incorrect data, or may have incorrect permissions. >How-To-Repeat: >Fix: >Release-Note: >Audit-Trail: >Unformatted: