From owner-freebsd-current Sun Apr 2 23:13:48 2000 Delivered-To: freebsd-current@freebsd.org Received: from rover.village.org (rover.village.org [204.144.255.49]) by hub.freebsd.org (Postfix) with ESMTP id E9C8237BBC5 for ; Sun, 2 Apr 2000 23:13:42 -0700 (PDT) (envelope-from imp@harmony.village.org) Received: from harmony.village.org (harmony.village.org [10.0.0.6]) by rover.village.org (8.9.3/8.9.3) with ESMTP id AAA86616; Mon, 3 Apr 2000 00:13:40 -0600 (MDT) (envelope-from imp@harmony.village.org) Received: from harmony.village.org (localhost.village.org [127.0.0.1]) by harmony.village.org (8.9.3/8.8.3) with ESMTP id AAA59095; Mon, 3 Apr 2000 00:13:03 -0600 (MDT) Message-Id: <200004030613.AAA59095@harmony.village.org> To: Takahashi Yoshihiro Subject: Re: Please review newbus patch for amd and adv Cc: current@FreeBSD.ORG In-reply-to: Your message of "Mon, 03 Apr 2000 15:09:08 +0900." <20000403150908J.nyan@wyvern.cc.kogakuin.ac.jp> References: <20000403150908J.nyan@wyvern.cc.kogakuin.ac.jp> <20000402230532V.nyan@dd.catv.ne.jp> <200004030103.TAA56398@harmony.village.org> Date: Mon, 03 Apr 2000 00:13:03 -0600 From: Warner Losh Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG In message <20000403150908J.nyan@wyvern.cc.kogakuin.ac.jp> Takahashi Yoshihiro writes: : Because, adv_isa.c is not required by PC-98, PC-98 requires only PCI : frontend. Then it contains isa_dmacascade function which does not : exist and is not needed for PC-98. Is that because there's not isa bus on a pc-98? Or that the adv_isa cannot possibly work on the ISA bus that is in a pc-98? If there's no isa on the pc98, then config should take care of not including it. So I'm a little confused here. If there is a isa bus, but it doesn't support dma, I think that we'd have problems with many different drivers, and not just adv. : The reason to comment out is to be clear that it is not required. If : it is completely removed from files.pc98, we may guess wrong in the : far future that we forgot to merge from files.i386. This part I understand. If it is a md file, then it makes sense to leave it commented out like you did. Warner To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message