From owner-svn-src-all@freebsd.org Wed Jun 27 23:07:23 2018 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 1CF8C101A46A; Wed, 27 Jun 2018 23:07:23 +0000 (UTC) (envelope-from dim@FreeBSD.org) Received: from tensor.andric.com (tensor.andric.com [87.251.56.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "tensor.andric.com", Issuer "COMODO RSA Domain Validation Secure Server CA" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 974F077D68; Wed, 27 Jun 2018 23:07:22 +0000 (UTC) (envelope-from dim@FreeBSD.org) Received: from coleburn.home.andric.com (coleburn.home.andric.com [192.168.0.15]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by tensor.andric.com (Postfix) with ESMTPSA id 427EED3E1; Thu, 28 Jun 2018 01:07:21 +0200 (CEST) From: Dimitry Andric Message-Id: <5223ED3B-6286-4A1B-8DB7-86BF11417F96@FreeBSD.org> Content-Type: multipart/signed; boundary="Apple-Mail=_6A998EB7-ED57-4FA0-8173-94C901A3FF1C"; protocol="application/pgp-signature"; micalg=pgp-sha1 Mime-Version: 1.0 (Mac OS X Mail 11.4 \(3445.8.2\)) Subject: Re: svn commit: r335733 - in head: bin/csh gnu/usr.bin/cc/cc1 gnu/usr.bin/cc/cc1plus gnu/usr.bin/cc/cc_tools lib/libmagic lib/libpam/static_libpam lib/ncurses/ncurses share/syscons/scrnmaps stand/mips/... Date: Thu, 28 Jun 2018 01:05:41 +0200 In-Reply-To: Cc: Bryan Drewery , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org To: John Baldwin References: <201806271929.w5RJTGwa049250@repo.freebsd.org> <1903115A-F018-4075-961A-65689595FBEE@FreeBSD.org> <0d1b366a-59ab-65e9-58a6-5474f538cad2@FreeBSD.org> X-Mailer: Apple Mail (2.3445.8.2) X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 27 Jun 2018 23:07:23 -0000 --Apple-Mail=_6A998EB7-ED57-4FA0-8173-94C901A3FF1C Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii On 27 Jun 2018, at 22:53, John Baldwin wrote: >=20 > On 6/27/18 12:45 PM, Bryan Drewery wrote: >> On 6/27/2018 12:35 PM, Dimitry Andric wrote: >>> On 27 Jun 2018, at 21:29, Bryan Drewery = wrote: >>>>=20 >>>> Author: bdrewery >>>> Date: Wed Jun 27 19:29:15 2018 >>>> New Revision: 335733 >>>> URL: https://svnweb.freebsd.org/changeset/base/335733 >>>>=20 >>>> Log: >>>> Don't use CCACHE for linking. >>>>=20 >>>> MFC after: 2 weeks >>>> Sponsored by: Dell EMC >>>>=20 >>>> Modified: >>>> head/bin/csh/Makefile >>>> head/gnu/usr.bin/cc/cc1/Makefile >>>> head/gnu/usr.bin/cc/cc1plus/Makefile >>>> head/gnu/usr.bin/cc/cc_tools/Makefile >>>> head/lib/libmagic/Makefile >>>> head/lib/libpam/static_libpam/Makefile >>>> head/lib/ncurses/ncurses/Makefile >>>> head/share/syscons/scrnmaps/Makefile >>>> head/stand/mips/beri/boot2/Makefile >>>> head/usr.bin/vi/catalog/Makefile >>>>=20 >>>> Modified: head/bin/csh/Makefile >>>> = =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D >>>> --- head/bin/csh/Makefile Wed Jun 27 19:28:37 2018 = (r335732) >>>> +++ head/bin/csh/Makefile Wed Jun 27 19:29:15 2018 = (r335733) >>>> @@ -113,7 +113,7 @@ build-tools: gethost >>>>=20 >>>> gethost: gethost.c sh.err.h tc.const.h sh.h ${BUILD_TOOLS_META} >>>> @rm -f ${.TARGET} >>>> - ${CC} -o gethost ${LDFLAGS} ${CFLAGS:C/-DHAVE_ICONV//} \ >>>> + ${CC:N${CCACHE_BIN}} -o gethost ${LDFLAGS} = ${CFLAGS:C/-DHAVE_ICONV//} \ >>>> ${TCSHDIR}/gethost.c >>>=20 >>> Looks like a good candidate for a common macro, say CC_NOCACHE, = CC_REAL >>> or something like that? :) >>=20 >> Yeah probably. I'd paint it CC_LINK. >=20 > CCLD was my initial thought *duck* Actually, that is not bad, and something I have seem more often. In the sense that ${LD} would be e.g. /usr/bin/ld or at least, a "low level" linker, while ${CCLD} would be the compiler driver doing the work. Maybe it is specifically for these cases, that you don't directly use ${CC}, but ${CCLD}... -Dimitry --Apple-Mail=_6A998EB7-ED57-4FA0-8173-94C901A3FF1C Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.2 iF0EARECAB0WIQR6tGLSzjX8bUI5T82wXqMKLiCWowUCWzQYRQAKCRCwXqMKLiCW o1W7AKD1Ca+ZFklz2ZjeRcF/mZddy6cQ/QCeLSq+JuNmemQx3IFByIgdcp3Fumg= =QkHv -----END PGP SIGNATURE----- --Apple-Mail=_6A998EB7-ED57-4FA0-8173-94C901A3FF1C--